Re: Mod to view secure https links in WikiLook

[Michael@Oz]

Thanks, I'll give that a go and let you know. If it works I'll mention it in the Add-on comments.

On Wednesday, July 8, 2015 at 12:20:00 PM UTC+10, Alan Stewart wrote:

I haven't been able to make WikiLook actually use https, but now that Wikipedia is redirecting all http requests to https, I have modded WikiLook to match https links and let Wikipedia do the work for me. This is a hack, not a fix.

I use PaleMoon, not Firefox, so I can't guarantee it will work there. Also, modding the xpi file voids the signed hash, so Firefox users will need to remove the META-INF signature folder, or figure out how to get it signed, or use the dev version of Firefox that doesn't check signing.

In the file chrome/wikilook/content/wikilook.js, there are two places where google is used for the smart lookup, line 8224 and line 9670. Change http to https in both.

Add to line 326, now an empty line, to be:

    evt.target.href = evt.target.href.replace(/^https/,"http");

WikiLook will still try to use http, but Wikipedia will redirect and WikiLook still gets the contents.

Also make the change I posted a year ago, nothing to do with https, to fix a syntax error in line 4746:

     globalPackageWL.WikiLook_Overlay.PMaker.WLWTajaxCallbackImpl(res.expandtemplates['*']);

The user options will still be the http urls.

If this works for any recent version Firefox user and you could mention it at addon.mozilla.org - private comments, that would be nice. I have never gotten my AMO account to work.

Alan

[Michael@Oz]

No doesn't work. FF 38.0.5.
It just deletes the .xpi, I removed the META-INF directory, there must be something elsewhere that knows it used to be signed...
No even a clean install after a remove doesn't work. It is listed in Add-ons, but no right-click menu item no response to keys&right-click.

I may try making a new add-on using the code. It is open-source.

On Wednesday, July 8, 2015 at 12:20:00 PM UTC+10, Alan Stewart wrote:

I haven't been able to make WikiLook actually use https, but now that Wikipedia is redirecting all http requests to https, I have modded WikiLook to match https links and let Wikipedia do the work for me. This is a hack, not a fix.

I use PaleMoon, not Firefox, so I can't guarantee it will work there. Also, modding the xpi file voids the signed hash, so Firefox users will need to remove the META-INF signature folder, or figure out how to get it signed, or use the dev version of Firefox that doesn't check signing.

In the file chrome/wikilook/content/wikilook.js, there are two places where google is used for the smart lookup, line 8224 and line 9670. Change http to https in both.

Add to line 326, now an empty line, to be:

    evt.target.href = evt.target.href.replace(/^https/,"http");

WikiLook will still try to use http, but Wikipedia will redirect and WikiLook still gets the contents.

Also make the change I posted a year ago, nothing to do with https, to fix a syntax error in line 4746:

     globalPackageWL.WikiLook_Overlay.PMaker.WLWTajaxCallbackImpl(res.expandtemplates['*']);

The user options will still be the http urls.

If this works for any recent version Firefox user and you could mention it at addon.mozilla.org comments, that would be nice. I have never gotten my AMO account to work.

Alan

[Alan Stewart]

WARNING: Don't use this mod. It modifies links on all pages, not just Wikipedia, so other https sites will be clobbered. Sorry for the snafu.

Alan Stewart