Verified submitted patch and small question (issue 9)

[Daniel Toffetti]

Hi,

I verified the patch submitted for issue 9, it seems to work fine:

http://code.google.com/p/wicket-web-beans/issues/detail?id=9

Currently, the @Target for @Property annotation are (TYPE,
METHOD), I wonder if is there any harm in adding FIELD target ??

Cheers,

Daniel

[Dan Syrstad]

No problem, but some code would have to detect the annotation on the field.

-Dan

--
You received this message because you are subscribed to the Google Groups "Wicket Web Beans" group.
To post to this group, send email to wicket-w...@googlegroups.com.
To unsubscribe from this group, send email to wicket-web-bea...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/wicket-web-beans?hl=en.

[Daniel Toffetti]

That's exactly what the submitted patch does. The javadoc for
BeanMetaData.deriveElementFromAnnotations() mentions annotations from
JPA, and they are usually field annotations. Once the annotations are
collected, then they can be consumed just as easily, is this right ?
I tested this feature changing @Property to @Target also FIELD,
and adding @Property(required=true) to a field, this worked fine.

Cheers,

Daniel

[Daniel Toffetti]

Just to close this thread, the patch is already committed.

Daniel