One more item to fix in the Standard skin

[jpb...@gmail.com]

...I'm not sure how you'd want this fixed, so I don't offer a patch this time. But, if in the Standard skin directory, you open up index.html.tmpl - then look for the string "footnote1". You'll see what I mean - the normal text of "This station is running WeeWX, an experimental..." is gone, replaced with those footnote references that never actually do anything.

I just cut/pasted what was there from the latest 4.5 release.

Not sure why I didn't notice that before - perhaps I've seen the WeeWX blurb so often that I don't 'register' when it's missing.

-Joel

[Tom Keffer]

This is "kind of" a bug. The gettext() redirection for "footnote1", et al., goes to the text in the locale files.  If you don't have a "lang" specified, then it doesn't know where to go, so no replacement is done: you see "footnote1", "footnote2", etc.

To fix, specify a "lang":

    [[Defaults]]
       
        # Which language to use for all reports. Not all skins support all languages.
        # You can override this for individual reports.
        lang = en
       

The assumption was that if a user upgraded, then s/he would have the old Standard skin, so the old version of weewx.conf would work. OTOH, if a brand-new install is done, then the new version of the Standard skin would be installed, along with a new version of weewx.conf, which includes the "lang" specification. I would guess that you upgraded, but replaced "Standard" with the new version.

Having said this, it really should default to something better. The right thing to do is what the Seasons skin does: instead of using "footnote1", etc., as the key, use the actual English string.

Fixed in commit c2d1a3a.

-tk

--
You received this message because you are subscribed to the Google Groups "weewx-development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to weewx-developm...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/weewx-development/aabe3fb4-8f54-456a-a7c6-17f8c8f709dfn%40googlegroups.com.