[Bug 30946] Extra layout on keypress after a space (problem with rebalanceWhitespaceAt in InsertTextCommand)
bugzill...@webkit.org
WebKit Review Bot <webkit.r...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |webkit-bot-watchers@googleg
| |roups.com,
| |webkit.r...@gmail.com
--- Comment #6 from WebKit Review Bot <webkit.r...@gmail.com> 2010-02-25 10:15:44 PST ---
Attachment 49506 did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/editing/htmlediting.cpp:447: Tests for true/false, null/non-null, and
zero/non-zero should all be done without equality comparisons.
[readability/comparison_to_zero] [5]
Total errors found: 1 in 28 files
If any of these errors are false positives, please file a bug against
check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
bugzill...@webkit.org
Enrica Casucci <enr...@apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49506|0 |1
is obsolete| |
Attachment #49506|review? |
Flag| |
Attachment #49510| |review?
Flag| |
--- Comment #7 from Enrica Casucci <enr...@apple.com> 2010-02-25 10:27:36 PST ---
Created an attachment (id=49510)
--> (https://bugs.webkit.org/attachment.cgi?id=49510)
Patch3
Fixed style issue.
bugzill...@webkit.org
Adele Peterson <ad...@apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #49510|review? |review+
Flag| |
bugzill...@webkit.org
Enrica Casucci <enr...@apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #8 from Enrica Casucci <enr...@apple.com> 2010-02-25 17:01:26 PST ---
Committed revision 55263.
bugzill...@webkit.org
Csaba Osztrogonac <os...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
CC| |os...@webkit.org
--- Comment #9 from Csaba Osztrogonac <os...@webkit.org> 2010-02-26 00:18:10 PST ---
This patch broke fast/forms/textarea-type-spaces-pretty-diff.html test on all
buildbot.
Tiger:
http://build.webkit.org/results/Tiger%20Intel%20Release/r55265%20%289128%29/fast/forms/textarea-type-spaces-pretty-diff.html
Leopard(debug):
http://build.webkit.org/results/Leopard%20Intel%20Debug%20%28Tests%29/r55264%20%2810851%29/fast/forms/textarea-type-spaces-pretty-diff.html
bugzill...@webkit.org
--- Comment #10 from Csaba Osztrogonac <os...@webkit.org> 2010-02-26 00:43:28 PST ---
I had to roll out r55263 to make buildbots and commit bot happier:
http://trac.webkit.org/changeset/55271 .
bugzill...@webkit.org
--- Comment #11 from Csaba Osztrogonac <os...@webkit.org> 2010-02-26 03:24:06 PST ---
The patch broke fast/events/key-events-in-input-text.html too:
bugzill...@webkit.org
--- Comment #12 from Enrica Casucci <enr...@apple.com> 2010-02-26 09:38:31 PST ---
(In reply to comment #11)
> The patch broke fast/events/key-events-in-input-text.html too:
>
> http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r55270%20%286022%29/fast/events/key-events-in-input-text-pretty-diff.html
I'm aware of the problem and I'm preparing a patch to fix the failing tests.
bugzill...@webkit.org
Eric Seidel <er...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |er...@webkit.org
--- Comment #13 from Eric Seidel <er...@webkit.org> 2010-05-17 01:46:19 PST ---
I'm unsure what the status of this bug is. It looks like this got landed and then rolled out. Presumably it was landed again? Should this bug be closed?