[Bug 21371] Cannot animate "points" attribute for <svg:polygon>
bugzill...@webkit.org
WebKit Review Bot <webkit.r...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |webkit-bot-watchers@googleg
| |roups.com,
| |webkit.r...@gmail.com
--- Comment #4 from WebKit Review Bot <webkit.r...@gmail.com> 2010-03-28 23:58:54 PST ---
Attachment 51861 did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/svg/SVGAnimateElement.cpp:149: Tests for true/false, null/non-null,
and zero/non-zero should all be done without equality comparisons.
[readability/comparison_to_zero] [5]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against
check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
bugzill...@webkit.org
--- Comment #5 from Dirk Schulze <kr...@webkit.org> 2010-03-29 00:31:10 PST ---
(In reply to comment #4)
> Attachment 51861 [details] did not pass style-queue:
>
> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> WebCore/svg/SVGAnimateElement.cpp:149: Tests for true/false, null/non-null,
> and zero/non-zero should all be done without equality comparisons.
> [readability/comparison_to_zero] [5]
> Total errors found: 1 in 9 files
>
>
> If any of these errors are false positives, please file a bug against
> check-webkit-style.
The value can be negative, so ... == 0 check is ok here.
bugzill...@webkit.org
WebKit Review Bot <webkit.r...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dgla...@chromium.org
--- Comment #6 from WebKit Review Bot <webkit.r...@gmail.com> 2010-03-29 00:57:44 PST ---
Attachment 51861 did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/1611047
bugzill...@webkit.org
Dirk Schulze <kr...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #51861|0 |1
is obsolete| |
Attachment #51861|review? |
Flag| |
Attachment #51885| |review?
Flag| |
--- Comment #7 from Dirk Schulze <kr...@webkit.org> 2010-03-29 01:46:27 PST ---
Created an attachment (id=51885)
--> (https://bugs.webkit.org/attachment.cgi?id=51885)
Patch
with build-fix for chromium
bugzill...@webkit.org
--- Comment #8 from WebKit Review Bot <webkit.r...@gmail.com> 2010-03-29 01:51:32 PST ---
Attachment 51885 did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/svg/SVGAnimateElement.cpp:149: Tests for true/false, null/non-null,
and zero/non-zero should all be done without equality comparisons.
[readability/comparison_to_zero] [5]
Total errors found: 1 in 11 files
If any of these errors are false positives, please file a bug against
check-webkit-style.
--
bugzill...@webkit.org
Nikolas Zimmermann <zimme...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #51885|review? |review+
Flag| |
--- Comment #9 from Nikolas Zimmermann <zimme...@kde.org> 2010-03-30 01:35:03 PST ---
(From update of attachment 51885)
Nice patch, some small comments before landing:
> Index: WebCore/svg/SVGPathSegList.h
> ===================================================================
> --- WebCore/svg/SVGPathSegList.h (revision 56693)
> +++ WebCore/svg/SVGPathSegList.h (working copy)
> @@ -45,6 +45,8 @@ namespace WebCore {
> SVGPathSegList(const QualifiedName&);
> };
>
> + float blendFunc(float from, float to, float progress);
Can you rename this function to something more descriptive?
> Index: WebCore/svg/SVGPointList.cpp
> + const FloatPoint from = fromList->getItem(n, ec);
> + const FloatPoint to = toList->getItem(n, ec);
Can't you omit const here?
Excellent testcase, r=me.
bugzill...@webkit.org
--- Comment #11 from Eric Seidel <er...@webkit.org> 2010-05-17 00:42:35 PST ---
Unsure of the status of this patch. It's been in pending-commit for over a month. Updates?
bugzill...@webkit.org
Dirk Schulze <kr...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #12 from Dirk Schulze <kr...@webkit.org> 2010-05-17 01:24:18 PST ---
Landed in http://trac.webkit.org/changeset/56795.