[Bug 38344] Remove custom bindings for HTMLInputElement
2 views
Skip to first unread message
bugzill...@webkit.org
May 14, 2010, 7:34:24 PM5/14/10
to webkit-bo...@googlegroups.com
https://bugs.webkit.org/show_bug.cgi?id=38344
Adam Barth <aba...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #8 from Adam Barth <aba...@webkit.org> 2010-05-14 16:34:21 PST ---
Committed r59502: <http://trac.webkit.org/changeset/59502>
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
Adam Barth <aba...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #8 from Adam Barth <aba...@webkit.org> 2010-05-14 16:34:21 PST ---
Committed r59502: <http://trac.webkit.org/changeset/59502>
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
bugzill...@webkit.org
May 14, 2010, 7:51:37 PM5/14/10
to webkit-bo...@googlegroups.com
https://bugs.webkit.org/show_bug.cgi?id=38344
Adam Barth <aba...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Adam Barth <aba...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |
--- Comment #9 from Adam Barth <aba...@webkit.org> 2010-05-14 16:51:33 PST ---
I landed the TestObj.idl changes in http://trac.webkit.org/changeset/59502. I'm going to post a new patch that addresses Darin's feedback shortly.
bugzill...@webkit.org
May 15, 2010, 1:06:46 AM5/15/10
to webkit-bo...@googlegroups.com
https://bugs.webkit.org/show_bug.cgi?id=38344
Adam Barth <aba...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #54732|0 |1
Adam Barth <aba...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
is obsolete| |
Attachment #54732|review+, commit-queue- |
Flag| |
bugzill...@webkit.org
May 15, 2010, 1:06:57 AM5/15/10
to webkit-bo...@googlegroups.com
https://bugs.webkit.org/show_bug.cgi?id=38344
--- Comment #10 from Adam Barth <aba...@webkit.org> 2010-05-14 22:06:51 PST ---
Created an attachment (id=56139)
--> (https://bugs.webkit.org/attachment.cgi?id=56139)
work in progress
--- Comment #10 from Adam Barth <aba...@webkit.org> 2010-05-14 22:06:51 PST ---
Created an attachment (id=56139)
--> (https://bugs.webkit.org/attachment.cgi?id=56139)
work in progress
bugzill...@webkit.org
May 15, 2010, 2:23:46 AM5/15/10
to webkit-bo...@googlegroups.com
https://bugs.webkit.org/show_bug.cgi?id=38344
Adam Barth <aba...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56139|0 |1
Adam Barth <aba...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
is obsolete| |
bugzill...@webkit.org
May 15, 2010, 2:23:52 AM5/15/10
to webkit-bo...@googlegroups.com
https://bugs.webkit.org/show_bug.cgi?id=38344
Adam Barth <aba...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56141| |review?
Adam Barth <aba...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |
--- Comment #11 from Adam Barth <aba...@webkit.org> 2010-05-14 23:23:49 PST ---
Created an attachment (id=56141)
--> (https://bugs.webkit.org/attachment.cgi?id=56141)
Patch
bugzill...@webkit.org
May 16, 2010, 3:12:44 PM5/16/10
to webkit-bo...@googlegroups.com
https://bugs.webkit.org/show_bug.cgi?id=38344
Darin Adler <da...@apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56141|review? |review+
Flag| |
--- Comment #12 from Darin Adler <da...@apple.com> 2010-05-16 12:12:41 PST ---
(From update of attachment 56141)
Good to avoid custom bindings.
Awkward to have these two versions of these basic functions side by side. The only other place I can think of where we have that is the Range class. Note the different way these functions are declared in that class compared to what we have in this patch. I think I like the Range style slightly better.
> + // The methods that take ExceptionCodes check canHaveSelection().
Methods is not a C++ term, and I normally avoid using it to mean member function in WebKit code. I would say "The following functions" or "These functions" rather than "The methods".
Darin Adler <da...@apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #56141|review? |review+
Flag| |
--- Comment #12 from Darin Adler <da...@apple.com> 2010-05-16 12:12:41 PST ---
(From update of attachment 56141)
Good to avoid custom bindings.
Awkward to have these two versions of these basic functions side by side. The only other place I can think of where we have that is the Range class. Note the different way these functions are declared in that class compared to what we have in this patch. I think I like the Range style slightly better.
> + // The methods that take ExceptionCodes check canHaveSelection().
Methods is not a C++ term, and I normally avoid using it to mean member function in WebKit code. I would say "The following functions" or "These functions" rather than "The methods".
Reply all
Reply to author
Forward
0 new messages