[Bug 38324] [Qt] Fix compilation with QT_NO_FEATURE

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38324


Simon Hausmann <haus...@webkit.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #54768|review?, commit-queue? |review+, commit-queue+
Flag| |




--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38324


WebKit Commit Bot <ese...@chromium.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #54768|commit-queue+ |commit-queue-
Flag| |




--- Comment #16 from WebKit Commit Bot <ese...@chromium.org> 2010-05-14 19:42:45 PST ---
(From update of attachment 54768)
Rejecting patch 54768 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Simon Hausmann', u'--force']" exit_code: 1
Last 500 characters of output:

patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/platform/graphics/qt/GraphicsLayerQt.cpp
Hunk #1 succeeded at 43 (offset -3 lines).
Hunk #2 succeeded at 92 (offset -3 lines).
Hunk #3 succeeded at 181 with fuzz 1 (offset -5 lines).
Hunk #4 succeeded at 531 (offset 36 lines).
Hunk #5 succeeded at 539 with fuzz 1 (offset 36 lines).
Hunk #6 FAILED at 617.
1 out of 6 hunks FAILED -- saving rejects to file WebCore/platform/graphics/qt/GraphicsLayerQt.cpp.rej

Full output: http://webkit-commit-queue.appspot.com/results/2266095

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38324


Adam Barth <aba...@webkit.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |aba...@webkit.org




--- Comment #17 from Adam Barth <aba...@webkit.org> 2010-05-15 00:16:33 PST ---
Please upload a new patch that applies cleanly to top of tree.

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38324


Tasuku Suzuki <tasuku...@nokia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #54711|0 |1
is obsolete| |
Attachment #56243| |review?, commit-queue?
Flag| |




--- Comment #18 from Tasuku Suzuki <tasuku...@nokia.com> 2010-05-17 07:23:01 PST ---
Created an attachment (id=56243)
--> (https://bugs.webkit.org/attachment.cgi?id=56243)
Patch to fix compilation with QT_NO_COMBOBOX

(In reply to comment #13)
> (From update of attachment 54711 [details])
> It seems that it might be better to just not compile the QtFallbackWebPopup at all when comboboxes are not supported.

Done.

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38324


Kenneth Rohde Christiansen <ken...@webkit.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #56243|review?, commit-queue? |review+, commit-queue+
Flag| |