[Bug 36454] Improve reporting of frame loader callbacks in DRT

bugzill...@webkit.org

unread,

Mar 22, 2010, 2:39:41 PM3/22/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

WebKit Review Bot <webkit.r...@gmail.com> changed:

--- Comment #4 from WebKit Review Bot <webkit.r...@gmail.com> 2010-03-22 11:39:41 PST ---
Attachment 51318 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp:810: Extra space before ( in
function call [whitespace/parens] [4]
WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp:812: Extra space before ( in
function call [whitespace/parens] [4]
Total errors found: 2 in 2 files

If any of these errors are false positives, please file a bug against
check-webkit-style.

--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

bugzill...@webkit.org

unread,

Mar 22, 2010, 2:41:30 PM3/22/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Sergio Villar Senin <svi...@igalia.com> changed:

--- Comment #5 from Sergio Villar Senin <svi...@igalia.com> 2010-03-22 11:41:30 PST ---
Created an attachment (id=51319)
--> (https://bugs.webkit.org/attachment.cgi?id=51319)
Print didCommitLoadForFrame in the callback of signal::load-committed

bugzill...@webkit.org

unread,

Mar 22, 2010, 2:42:21 PM3/22/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

--- Comment #6 from Sergio Villar Senin <svi...@igalia.com> 2010-03-22 11:42:21 PST ---
Created an attachment (id=51320)
--> (https://bugs.webkit.org/attachment.cgi?id=51320)
Added "onload-event" signal to WebKitWebView. Fix several loading tests

This patch does:
* Added "onload-event" signal to WebKitWebView
* FrameLoader emits onload-event when handling dispatchDidHandleOnloadEvents
* Removed 5 tests from Skipped file

bugzill...@webkit.org

unread,

Mar 25, 2010, 4:52:40 AM3/25/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Eric Seidel <er...@webkit.org> changed:

--- Comment #7 from Eric Seidel <er...@webkit.org> 2010-03-25 01:52:40 PST ---
(From update of attachment 51316)
Change looks OK, but you need to fill in the ChangeLog with information about
the change. See http://webkit.org/coding/contributing.html

bugzill...@webkit.org

unread,

Mar 25, 2010, 4:53:33 AM3/25/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Eric Seidel <er...@webkit.org> changed:

--- Comment #8 from Eric Seidel <er...@webkit.org> 2010-03-25 01:53:33 PST ---
(From update of attachment 51317)
Change again looks OK, but ChangeLog needs work. see
http://webkit.org/coding/contributing.html.

ChangeLogs are important both for the review of patches, and for when other
people wish to understand what your code does (during svn annotate, etc.)

bugzill...@webkit.org

unread,

Mar 25, 2010, 4:54:17 AM3/25/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Eric Seidel <er...@webkit.org> changed:

--- Comment #9 from Eric Seidel <er...@webkit.org> 2010-03-25 01:54:17 PST ---
(From update of attachment 51318)
Again looks fine. Again needs ChangeLog.

Shouldn't tests be un-skipped after these changes?

bugzill...@webkit.org

unread,

Mar 25, 2010, 4:54:36 AM3/25/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Eric Seidel <er...@webkit.org> changed:

--- Comment #10 from Eric Seidel <er...@webkit.org> 2010-03-25 01:54:36 PST ---
(From update of attachment 51319)
ChangeLog :(

bugzill...@webkit.org

unread,

Mar 25, 2010, 5:53:41 AM3/25/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Sergio Villar Senin <svi...@igalia.com> changed:

bugzill...@webkit.org

unread,

Mar 25, 2010, 7:08:37 AM3/25/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Sergio Villar Senin <svi...@igalia.com> changed:

--- Comment #11 from Sergio Villar Senin <svi...@igalia.com> 2010-03-25 04:08:37 PST ---
Created an attachment (id=51622)
--> (https://bugs.webkit.org/attachment.cgi?id=51622)
Print didFinishLoadForFrame outcome in DRT

Improved Changelog

bugzill...@webkit.org

unread,

Mar 25, 2010, 7:09:08 AM3/25/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Sergio Villar Senin <svi...@igalia.com> changed:

--- Comment #12 from Sergio Villar Senin <svi...@igalia.com> 2010-03-25 04:09:08 PST ---
Created an attachment (id=51623)
--> (https://bugs.webkit.org/attachment.cgi?id=51623)
Add a CR after printing didFinishDocumentLoadForFrame

bugzill...@webkit.org

unread,

Mar 25, 2010, 7:09:37 AM3/25/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Sergio Villar Senin <svi...@igalia.com> changed:

--- Comment #13 from Sergio Villar Senin <svi...@igalia.com> 2010-03-25 04:09:37 PST ---
Created an attachment (id=51624)
--> (https://bugs.webkit.org/attachment.cgi?id=51624)
Print didStartProvisionalLoadForFrame in the callback of notify::load-status
property change notification

bugzill...@webkit.org

unread,

Mar 25, 2010, 7:10:17 AM3/25/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Sergio Villar Senin <svi...@igalia.com> changed:

--- Comment #14 from Sergio Villar Senin <svi...@igalia.com> 2010-03-25 04:10:16 PST ---
Created an attachment (id=51625)
--> (https://bugs.webkit.org/attachment.cgi?id=51625)
Print didCommitLoadForFrame in the callback of signal::load-committed

bugzill...@webkit.org

unread,

Mar 25, 2010, 7:10:42 AM3/25/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Sergio Villar Senin <svi...@igalia.com> changed:

--- Comment #15 from Sergio Villar Senin <svi...@igalia.com> 2010-03-25 04:10:42 PST ---
Created an attachment (id=51626)
--> (https://bugs.webkit.org/attachment.cgi?id=51626)

Added "onload-event" signal to WebKitWebView. Fix several loading tests

--

bugzill...@webkit.org

unread,

Mar 25, 2010, 7:11:58 AM3/25/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

--- Comment #16 from Sergio Villar Senin <svi...@igalia.com> 2010-03-25 04:11:58 PST ---
I sent small patches to make them easier to review. If committing small patches
is a problem I can create a single one.

bugzill...@webkit.org

unread,

Mar 26, 2010, 4:29:42 PM3/26/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Eric Seidel <er...@webkit.org> changed:

--- Comment #17 from Eric Seidel <er...@webkit.org> 2010-03-26 13:29:42 PST ---
(From update of attachment 51622)
Yay! Looking forward to the un-skipping!

bugzill...@webkit.org

unread,

Mar 26, 2010, 4:29:57 PM3/26/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Eric Seidel <er...@webkit.org> changed:

--- Comment #18 from Eric Seidel <er...@webkit.org> 2010-03-26 13:29:57 PST ---
(From update of attachment 51623)

bugzill...@webkit.org

unread,

Mar 26, 2010, 4:30:38 PM3/26/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Eric Seidel <er...@webkit.org> changed:

--- Comment #19 from Eric Seidel <er...@webkit.org> 2010-03-26 13:30:38 PST ---
(From update of attachment 51624)
Excellent.

bugzill...@webkit.org

unread,

Mar 26, 2010, 4:31:00 PM3/26/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Eric Seidel <er...@webkit.org> changed:

--- Comment #20 from Eric Seidel <er...@webkit.org> 2010-03-26 13:31:00 PST ---
(From update of attachment 51625)
OK.

bugzill...@webkit.org

unread,

Mar 26, 2010, 4:31:46 PM3/26/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Eric Seidel <er...@webkit.org> changed:

--- Comment #21 from Eric Seidel <er...@webkit.org> 2010-03-26 13:31:46 PST ---
(From update of attachment 51626)

bugzill...@webkit.org

unread,

Mar 26, 2010, 6:16:18 PM3/26/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

WebKit Commit Bot <ese...@chromium.org> changed:

--- Comment #22 from WebKit Commit Bot <ese...@chromium.org> 2010-03-26 15:16:18 PST ---
(From update of attachment 51622)
Clearing flags on attachment: 51622

Committed r56645: <http://trac.webkit.org/changeset/56645>

bugzill...@webkit.org

unread,

Mar 26, 2010, 6:39:29 PM3/26/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Eric Seidel <er...@webkit.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |er...@webkit.org

--- Comment #23 from Eric Seidel <er...@webkit.org> 2010-03-26 15:39:29 PST ---
Looks like the first checkin caused a test failure:
http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r56645%20(1381)/http/tests/loading/redirect-with-no-location-crash-pretty-diff.html

Maybe that will stop failign once they're all checked in?

bugzill...@webkit.org

unread,

Mar 27, 2010, 6:26:26 AM3/27/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

--- Comment #24 from Sergio Villar Senin <svi...@igalia.com> 2010-03-27 03:26:25 PST ---
(In reply to comment #23)

> Looks like the first checkin caused a test failure:
> http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r56645%20(1381)/http/tests/loading/redirect-with-no-location-crash-pretty-diff.html
>
> Maybe that will stop failign once they're all checked in?

Looks like that's the case. Should be fixed by
https://bugs.webkit.org/attachment.cgi?id=51623 as it needs a CR after the
didFinishDocumentLoadForFrame

bugzill...@webkit.org

unread,

Mar 27, 2010, 9:07:38 PM3/27/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

WebKit Commit Bot <ese...@chromium.org> changed:

--- Comment #25 from WebKit Commit Bot <ese...@chromium.org> 2010-03-27 18:07:38 PST ---
(From update of attachment 51623)
Clearing flags on attachment: 51623

Committed r56674: <http://trac.webkit.org/changeset/56674>

bugzill...@webkit.org

unread,

Mar 28, 2010, 1:34:37 AM3/28/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

WebKit Commit Bot <ese...@chromium.org> changed:

--- Comment #26 from WebKit Commit Bot <ese...@chromium.org> 2010-03-27 22:34:37 PST ---
(From update of attachment 51624)
Clearing flags on attachment: 51624

Committed r56679: <http://trac.webkit.org/changeset/56679>

bugzill...@webkit.org

unread,

Mar 28, 2010, 1:52:04 AM3/28/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

WebKit Commit Bot <ese...@chromium.org> changed:

--- Comment #27 from WebKit Commit Bot <ese...@chromium.org> 2010-03-27 22:52:03 PST ---
(From update of attachment 51625)
Clearing flags on attachment: 51625

Committed r56680: <http://trac.webkit.org/changeset/56680>

bugzill...@webkit.org

unread,

Mar 28, 2010, 2:09:33 AM3/28/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

WebKit Commit Bot <ese...@chromium.org> changed:

--- Comment #28 from WebKit Commit Bot <ese...@chromium.org> 2010-03-27 23:09:32 PST ---
(From update of attachment 51626)
Clearing flags on attachment: 51626

Committed r56681: <http://trac.webkit.org/changeset/56681>

bugzill...@webkit.org

unread,

Mar 28, 2010, 2:09:39 AM3/28/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

WebKit Commit Bot <ese...@chromium.org> changed:

--- Comment #29 from WebKit Commit Bot <ese...@chromium.org> 2010-03-27 23:09:38 PST ---
All reviewed patches have been landed. Closing bug.

bugzill...@webkit.org

unread,

Mar 28, 2010, 12:14:11 PM3/28/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Eric Seidel <er...@webkit.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |g...@gnome.org

--- Comment #30 from Eric Seidel <er...@webkit.org> 2010-03-28 09:14:10 PST ---
These shoudl only be dumping when "dump loader callbacks" is enabled.

This is causing many non-loader tests to fail:
http://build.webkit.org/results/GTK%20Linux%2032-bit%20Release/r56693%20(10481)/accessibility/aria-activedescendant-crash-pretty-diff.html

And should be rolled out unless someone with a Gtk build is willing to make a
fix.

bugzill...@webkit.org

unread,

Mar 28, 2010, 12:15:06 PM3/28/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

--- Comment #31 from Eric Seidel <er...@webkit.org> 2010-03-28 09:15:05 PST ---
My apologies for not spotting the error in my review.

bugzill...@webkit.org

unread,

Mar 28, 2010, 6:31:24 PM3/28/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Gustavo Noronha (kov) <g...@gnome.org> changed:

--- Comment #32 from Gustavo Noronha (kov) <g...@gnome.org> 2010-03-28 15:31:24 PST ---
I am rolling out. Let's please test patches that alter DRT with all tests
before putting up for review, and landing.

bugzill...@webkit.org

unread,

Mar 28, 2010, 6:50:20 PM3/28/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

--- Comment #33 from Eric Seidel <er...@webkit.org> 2010-03-28 15:50:20 PST ---
Thank you Gustavo. Sorry for the trouble.

bugzill...@webkit.org

unread,

Mar 29, 2010, 4:33:39 AM3/29/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

--- Comment #34 from Sergio Villar Senin <svi...@igalia.com> 2010-03-29 01:33:39 PST ---
(In reply to comment #32)

> I am rolling out. Let's please test patches that alter DRT with all tests
> before putting up for review, and landing.

Ups, my fault. I'll upload new versions of the patches

bugzill...@webkit.org

unread,

Mar 29, 2010, 10:57:35 AM3/29/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Sergio Villar Senin <svi...@igalia.com> changed:

--- Comment #35 from Sergio Villar Senin <svi...@igalia.com> 2010-03-29 07:57:34 PST ---
Created an attachment (id=51909)
--> (https://bugs.webkit.org/attachment.cgi?id=51909)
Print didStartProvisionalLoadForFram in the callback of signal::load-committed

This new version only prints the output when needed

bugzill...@webkit.org

unread,

Mar 29, 2010, 10:58:07 AM3/29/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Sergio Villar Senin <svi...@igalia.com> changed:

bugzill...@webkit.org

unread,

Apr 1, 2010, 8:40:22 PM4/1/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

--- Comment #36 from Eric Seidel <er...@webkit.org> 2010-04-01 17:40:22 PST ---
(From update of attachment 51909)
Should this be keyed on database callbacks?
849 if (gLayoutTestController->dumpDatabaseCallbacks()) {

bugzill...@webkit.org

unread,

May 15, 2010, 2:55:24 AM5/15/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Adam Barth <aba...@webkit.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #52947| |commit-queue+
Flag| |

--- Comment #41 from Adam Barth <aba...@webkit.org> 2010-05-14 23:55:23 PST ---
(From update of attachment 52947)
This patch has been sitting in pending-commit for over a month. Hopefully it still works.

bugzill...@webkit.org

unread,

May 15, 2010, 1:12:50 PM5/15/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

WebKit Commit Bot <ese...@chromium.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #52947|commit-queue+ |commit-queue-
Flag| |

--- Comment #42 from WebKit Commit Bot <ese...@chromium.org> 2010-05-15 10:12:48 PST ---

(From update of attachment 52947)

Rejecting patch 52947 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Gustavo Noronha Silva', u'--force']" exit_code: 1
Last 500 characters of output:
).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/gtk/Skipped
Hunk #1 succeeded at 3313 (offset -103 lines).
Hunk #2 FAILED at 5771.
1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/gtk/Skipped.rej
patching file WebKitTools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp
Hunk #1 succeeded at 843 (offset 1 line).
Hunk #2 succeeded at 884 (offset 1 line).

Full output: http://webkit-commit-queue.appspot.com/results/2307110

bugzill...@webkit.org

unread,

May 15, 2010, 9:06:00 PM5/15/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Adam Barth <aba...@webkit.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #51622|0 |1
is obsolete| |

bugzill...@webkit.org

unread,

May 15, 2010, 9:06:06 PM5/15/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Adam Barth <aba...@webkit.org> changed:

What |Removed |Added
----------------------------------------------------------------------------

Attachment #51623|0 |1

bugzill...@webkit.org

unread,

May 15, 2010, 9:06:11 PM5/15/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Adam Barth <aba...@webkit.org> changed:

What |Removed |Added
----------------------------------------------------------------------------

Attachment #51625|0 |1

bugzill...@webkit.org

unread,

May 15, 2010, 9:06:17 PM5/15/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Adam Barth <aba...@webkit.org> changed:

What |Removed |Added
----------------------------------------------------------------------------

Attachment #51626|0 |1

bugzill...@webkit.org

unread,

May 15, 2010, 9:06:22 PM5/15/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Adam Barth <aba...@webkit.org> changed:

What |Removed |Added
----------------------------------------------------------------------------

bugzill...@webkit.org

unread,

May 15, 2010, 9:06:29 PM5/15/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

Adam Barth <aba...@webkit.org> changed:

What |Removed |Added
----------------------------------------------------------------------------

Attachment #56169| |commit-queue+
Flag| |

--- Comment #43 from Adam Barth <aba...@webkit.org> 2010-05-15 18:06:27 PST ---
Created an attachment (id=56169)
--> (https://bugs.webkit.org/attachment.cgi?id=56169)
Patch for landing

bugzill...@webkit.org

unread,

May 16, 2010, 3:44:46 AM5/16/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

WebKit Commit Bot <ese...@chromium.org> changed:

--- Comment #44 from WebKit Commit Bot <ese...@chromium.org> 2010-05-16 00:44:45 PST ---
(From update of attachment 56169)
Clearing flags on attachment: 56169

Committed r59568: <http://trac.webkit.org/changeset/59568>

bugzill...@webkit.org

unread,

May 16, 2010, 3:44:55 AM5/16/10

to webkit-bo...@googlegroups.com

https://bugs.webkit.org/show_bug.cgi?id=36454

WebKit Commit Bot <ese...@chromium.org> changed:

What |Removed |Added
----------------------------------------------------------------------------

Status|UNCONFIRMED |RESOLVED
Resolution| |FIXED

--- Comment #45 from WebKit Commit Bot <ese...@chromium.org> 2010-05-16 00:44:54 PST ---

All reviewed patches have been landed. Closing bug.

Reply all

Reply to author

Forward