[Bug 37684] [Qt] JSValue QtClass::fallbackObject can be optimized

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37684


WebKit Commit Bot <ese...@chromium.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |ese...@chromium.org,
| |webkit-bot-watchers@googleg
| |roups.com




--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37684


WebKit Commit Bot <ese...@chromium.org> changed:

What |Removed |Added
----------------------------------------------------------------------------

Attachment #55837|commit-queue+ |commit-queue-
Flag| |




--- Comment #8 from WebKit Commit Bot <ese...@chromium.org> 2010-05-14 00:56:13 PST ---
(From update of attachment 55837)
Rejecting patch 55837 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 2
Parsed 2 diffs from patch file(s).
patching file WebCore/ChangeLog
patch: **** malformed patch at line 18: 2010-04-15 Adam Roben <aro...@apple.com>

patching file WebCore/bridge/qt/qt_class.cpp

Full output: http://webkit-commit-queue.appspot.com/results/2315058

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37684





--- Comment #9 from Anders Bakken <agba...@gmail.com> 2010-05-14 03:19:44 PST ---
Created an attachment (id=56062)
--> (https://bugs.webkit.org/attachment.cgi?id=56062)
New version of the patch

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37684


Anders Bakken <agba...@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #56062| |review?, commit-queue?
Flag| |

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37684


Kenneth Rohde Christiansen <ken...@webkit.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #56062|review?, commit-queue? |review+, commit-queue+

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37684


WebKit Commit Bot <ese...@chromium.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #56062|commit-queue+ |commit-queue-
Flag| |




--- Comment #10 from WebKit Commit Bot <ese...@chromium.org> 2010-05-15 00:51:26 PST ---
(From update of attachment 56062)
Rejecting patch 56062 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing/iframes', '--quiet']" exit_code: 1
Last 500 characters of output:
ng Java tests
make: Nothing to be done for `default'.
Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests
Skipped list contained 'compositing/iframes/composited-iframe.html', but no file of that name could be found
Testing 18341 test cases.
fast/loader/recursive-before-unload-crash.html -> failed

Exiting early after 1 failures. 13417 tests run.
198.65s total testing time

13416 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
4 test cases (<1%) had stderr output

Full output: http://webkit-commit-queue.appspot.com/results/2265108

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37684





--- Comment #11 from Kenneth Rohde Christiansen <ken...@webkit.org> 2010-05-15 12:32:49 PST ---
Anders, you cannot remove the "Reviewed by NOBODY (OOPS!!)". If you do that we cannot land using the commit-queue. It has to be exactly like the prepare-ChangeLog scripts writes it.

Now you can reupload the patch with this fixed and reset r? and cq?

-- or --

You can upload the patch with "Reviewed by Kenneth Rohde Christiansen" and just set cq?

The latter is preferred as anyone with committer-rights can change the cq? to cq+

Another option would be to get someone to land it manually using webkit-patch or similar.

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37684


Adam Barth <aba...@webkit.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #56062|commit-queue- |commit-queue+
Flag| |




--- Comment #12 from Adam Barth <aba...@webkit.org> 2010-05-15 17:55:32 PST ---

(From update of attachment 56062)

I think you were just bit by a flaky test.

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37684


WebKit Commit Bot <ese...@chromium.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #56062|review+, commit-queue+ |
Flag| |




--- Comment #13 from WebKit Commit Bot <ese...@chromium.org> 2010-05-15 19:52:32 PST ---

(From update of attachment 56062)

Clearing flags on attachment: 56062

Committed r59563: <http://trac.webkit.org/changeset/59563>

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37684


WebKit Commit Bot <ese...@chromium.org> changed:

What |Removed |Added
----------------------------------------------------------------------------

Status|NEW |RESOLVED
Resolution| |FIXED




--- Comment #14 from WebKit Commit Bot <ese...@chromium.org> 2010-05-15 19:52:38 PST ---
All reviewed patches have been landed. Closing bug.

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37684


Simon Hausmann <haus...@webkit.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |haus...@webkit.org




--- Comment #15 from Simon Hausmann <haus...@webkit.org> 2010-05-16 00:58:58 PST ---
Revision r59563 cherry-picked into qtwebkit-2.0 with commit 4bb49bb59d4f763069ae6bb84b9648d6ed0bfd1d

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37684


Simon Hausmann <haus...@webkit.org> changed:

What |Removed |Added
----------------------------------------------------------------------------

Status|RESOLVED |CLOSED

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37684


Kimmo Kinnunen <kimmo.t....@nokia.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |kimmo.t....@nokia.com




--- Comment #16 from Kimmo Kinnunen <kimmo.t....@nokia.com> 2010-05-17 05:25:35 PST ---
This commit causes a bug which prevents signals from being matched.

It introduces second local variable named "index", which then overrides the proper method number variable (also called "index")

this causes signals from being found in some cases.

The affected line is:
QtRuntimeMetaMethod* val = new (exec) QtRuntimeMetaMethod(exec, identifier, static_cast<QtInstance*>(inst), index, normal, false);

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37684





--- Comment #17 from Kenneth Rohde Christiansen <ken...@webkit.org> 2010-05-17 05:32:04 PST ---
Uh, I wasn't able to see that from the diff. I will fix it later today

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37684


Kenneth Rohde Christiansen <ken...@webkit.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|CLOSED |REOPENED
Resolution|FIXED |




--- Comment #18 from Kenneth Rohde Christiansen <ken...@webkit.org> 2010-05-17 05:40:50 PST ---
Patch shadowed a variable.

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37684


Kenneth Rohde Christiansen <ken...@webkit.org> changed:

What |Removed |Added
----------------------------------------------------------------------------

Status|REOPENED |RESOLVED
Resolution| |FIXED




--- Comment #19 from Kenneth Rohde Christiansen <ken...@webkit.org> 2010-05-17 06:50:28 PST ---
Fixed regression in r59606

[bugzill...@webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37684





--- Comment #20 from Anders Bakken <agba...@gmail.com> 2010-05-17 07:37:32 PST ---
Oops. My bad.