[Bug 32509] [Qt] 3rd edition phones lack character echo in web input fields
bugzill...@webkit.org
WebKit Review Bot <webkit.r...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |webkit-bot-watchers@googleg
| |roups.com,
| |webkit.r...@gmail.com
--- Comment #9 from WebKit Review Bot <webkit.r...@gmail.com> 2010-01-08 02:53:30 PST ---
Attachment 46124 did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/rendering/RenderText.h:183: Should have a space between // and comment
[whitespace/comments] [4]
WebCore/ChangeLog:14: Line contains tab character. [whitespace/tab] [5]
WebCore/ChangeLog:15: Line contains tab character. [whitespace/tab] [5]
WebCore/ChangeLog:18: Line contains tab character. [whitespace/tab] [5]
Total errors found: 4
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
bugzill...@webkit.org
Petri Ojala <peoj...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #46124|0 |1
is obsolete| |
Attachment #46124|review? |
Flag| |
Attachment #46125| |review?
Flag| |
--- Comment #10 from Petri Ojala <peoj...@gmail.com> 2010-01-08 03:01:29 PST ---
Created an attachment (id=46125)
--> (https://bugs.webkit.org/attachment.cgi?id=46125)
Updated patch
Updated patch
bugzill...@webkit.org
--- Comment #11 from WebKit Review Bot <webkit.r...@gmail.com> 2010-01-08 03:04:15 PST ---
style-queue ran check-webkit-style on attachment 46125 without any errors.
bugzill...@webkit.org
Kristian Amlie <kristia...@nokia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kristia...@nokia.com
--- Comment #12 from Kristian Amlie <kristia...@nokia.com> 2010-01-15 08:18:54 PST ---
I think a much more correct fix for this problem is to implement the timer
logic in the input methods of Qt, by having it sending preedit text to the
widget and only commit it after the timer expires. That would be a generic fix
that would work for all Qt widgets and webkit as well. It would render this bug
moot, so I'm going to try that next week.
bugzill...@webkit.org
Simon Hausmann <haus...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #46125|review? |review-
Flag| |
--- Comment #13 from Simon Hausmann <haus...@webkit.org> 2010-01-16 00:42:57 PST ---
(From update of attachment 46125)
At the least this should not be just be PLATFORM(SYMBIAN) #ifdef'fed. The same
feature is needed for example on Maemo 5, too.
However if Kristian can solve this inside Qt's input method, then that's of
course the cleanest solution, as it would fix all occurrences of this problem
in one place.
bugzill...@webkit.org
--- Comment #14 from Kristian Amlie <kristia...@nokia.com> 2010-01-25 02:51:33 PST ---
Ok, this has been solved for general Qt widgets by introducing a temporary
1-second preedit text in the input methods that Qt uses (commit 87ee066fc86 in
the Qt repository).
This bug is still valid though, since WebKit does not display preedit text as
clear text, but masks that also as password text. This is IMO a bug, since this
makes any kind of advanced input into a password field nearly impossible. The
suggested fix is now to fix WebKit to display this preedit text also in
password fields. Whether or not you want to reuse this bug report for that
issue or not, I leave to you.
bugzill...@webkit.org
Tor Arne Vestbø <ves...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|webkit-u...@lists.web |peoj...@gmail.com
|kit.org |
bugzill...@webkit.org
Samuel Nevala <samuel...@digia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #53671|0 |1
is obsolete| |
Attachment #56235| |review?, commit-queue?
Flag| |
--- Comment #25 from Samuel Nevala <samuel...@digia.com> 2010-05-17 04:59:07 PST ---
Created an attachment (id=56235)
--> (https://bugs.webkit.org/attachment.cgi?id=56235)
Latest_Patch
bugzill...@webkit.org
--- Comment #26 from WebKit Review Bot <webkit.r...@gmail.com> 2010-05-17 05:01:12 PST ---
Attachment 56235 did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WARNING: File exempt from style guide. Skipping: "WebKit/qt/tests/qwebpage/tst_qwebpage.cpp"
WebCore/dom/CharacterData.cpp:164: Missing spaces around == [whitespace/operators] [3]
WebCore/dom/CharacterData.cpp:229: Missing space before ( in if( [whitespace/parens] [5]
WebCore/dom/CharacterData.cpp:229: Mismatching spaces inside () in if [whitespace/parens] [5]
WebCore/rendering/RenderText.cpp:1077: Missing space before ( in if( [whitespace/parens] [5]
Total errors found: 4 in 13 files
If any of these errors are false positives, please file a bug against check-webkit-style.