[Bug 28054] use derefInNotNull function to work around winscw compiler bug regarding template arguments.
bugzill...@webkit.org
WebKit Review Bot <webkit.r...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |webkit-bot-watchers@googleg
| |roups.com,
| |webkit.r...@gmail.com
--- Comment #40 from WebKit Review Bot <webkit.r...@gmail.com> 2010-02-10 01:54:09 PST ---
Attachment 48476 did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/wtf/RefPtr.h:60: More than one command on the same line
[whitespace/newline] [4]
Total errors found: 1
If any of these errors are false positives, please file a bug against
check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
bugzill...@webkit.org
Tor Arne Vestbø <ves...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ves...@webkit.org
--- Comment #41 from Tor Arne Vestbø <ves...@webkit.org> 2010-02-10 03:23:46 PST ---
(In reply to comment #40)
> Attachment 48476 [details] did not pass style-queue:
> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> JavaScriptCore/wtf/RefPtr.h:60: More than one command on the same line
> [whitespace/newline] [4]
> Total errors found: 1
[whopper:~/dev/webkit/wip] $ git grep -E ') {.*; [A-Za-z]+' -- **/*.h | wc -l
270
Eric, would it make sense to skip this check for headers, like we do for macros
and switch cases?
bugzill...@webkit.org
Tor Arne Vestbø <ves...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
is obsolete| |
Attachment #48480| |review?
Flag| |
--- Comment #42 from Tor Arne Vestbø <ves...@webkit.org> 2010-02-10 03:31:19 PST ---
Created an attachment (id=48480)
--> (https://bugs.webkit.org/attachment.cgi?id=48480)
Split up removal of bool hack into separate patch
bugzill...@webkit.org
Simon Hausmann <haus...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #48480|review? |review+
Flag| |
bugzill...@webkit.org
Tor Arne Vestbø <ves...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #48476|0 |1
is obsolete| |
Attachment #48476|review? |
Flag| |
Attachment #48481| |review?
Flag| |
--- Comment #43 from Tor Arne Vestbø <ves...@webkit.org> 2010-02-10 03:35:54 PST ---
Created an attachment (id=48481)
--> (https://bugs.webkit.org/attachment.cgi?id=48481)
Split up drefIfNotNull() patch
bugzill...@webkit.org
--- Comment #44 from WebKit Review Bot <webkit.r...@gmail.com> 2010-02-10 03:38:27 PST ---
Attachment 48481 did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/wtf/RefPtr.h:60: More than one command on the same line
[whitespace/newline] [4]
Total errors found: 1
If any of these errors are false positives, please file a bug against
check-webkit-style.
--
bugzill...@webkit.org
Simon Hausmann <haus...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #48481|review? |review+
Flag| |
--- Comment #45 from Simon Hausmann <haus...@webkit.org> 2010-02-10 03:44:40 PST ---
(From update of attachment 48481)
Treating the style as false positive and considering that this is the same as
r47592, it looks good to me.
bugzill...@webkit.org
Tor Arne Vestbø <ves...@webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #39431|application/octet-stream |text/plain
mime type| |
bugzill...@webkit.org
--- Comment #46 from Eric Seidel <er...@webkit.org> 2010-05-17 00:36:28 PST ---
Did this land? This has been in the pending-commit list for months. :(