new features?

[peter hausel]

Hi all,

I implemented a few features which I was missing from webbit:

- added support for cookie attributes (replacing the hand-rolled cookie implementation with a netty based one)

- added support for chunked responses (ie http streaming)

- upgraded netty

- added support for chunked requests (ie support for reactive file uploading) [well, this one is work-in-progress at the moment]

I sent most of these changes upstream via pull requests. 

Please let me know if you find any of these useful.

Thanks,

peter

[Joe Walnes]

Thanks for the contributions Peter!

We shall review these individually and get back to you. Be patient though - it can take some time.

cheers

-Joe

[Luke Hutchison]

I wanted to put a plug in for this -- chunked responses would be very helpful, they can make for much faster page render times if your content takes a while to generate (the resources in the head element can be fetched in parallel while the body is being generated).

Here is that specific pull request: https://github.com/webbit/webbit/pull/106

PS on the cookie issue, the java.net.HttpCookie that is used in Webbit in a few places is actually not functional with modern browsers: It will send a path field with something like the following, and the quotes are not stripped (in accordance with the relevant RFC) by either Chrome or Firefox in recent versions, so cookie paths can't be set: $Path="/"

Thanks!

[peter hausel]

PS on the cookie issue, the java.net.HttpCookie that is used in Webbit in a few places is actually not functional with modern browsers: It will send a path field with something like the following, and the quotes are not stripped (in accordance with the relevant RFC) by either Chrome or Firefox in recent versions, so cookie paths can't be set: $Path="/"

Hi Luke,

You may want to take a look at this PR:

https://github.com/webbit/webbit/pull/108

[peter hausel]

What I meant was that here: https://github.com/webbit/webbit/pull/108/files#L1L99

I replaced the serialization of java.net.HttpCookie with netty's cookie encoder which I think produces proper path.

[Luke Hutchison]

Yes, thanks for that. I started going through your pull requests, and there are quite a few useful bits in there. I might end up switching to your branch for now. (I just hope I don't start relying on API or behavioral changes that don't end up compatible with future Webbit head.)

--
You received this message because you are subscribed to a topic in the Google Groups "Webbit" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/webbit/hEbFW3q0Vks/unsubscribe?hl=en.
To unsubscribe from this group and all its topics, send an email to webbit+un...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[peter hausel]

For what it's worth, I am planning to maintain my changes (since I am using those features in my projects already).