--
You received this message because you are subscribed to the Google Groups "Webbit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to webbit+un...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
--
Hi Aslak,here is my attempt to fix the tests:https://github.com/webbit/webbit/pull/116
assuming this fixes Travis, could you please merge my pending PR-s before the release?
On Wednesday, 24 April 2013 at 14:42, peter hausel wrote:
Now that it looks like the problematic netty version is 3.5.7, would not make sense to upgrade to 3.5.5[1] at least?from 3.5.3 to 3.5.5 there were quite a few important fixes:- fix for connection leaks in SSL handler (when throwing exceptions)- cookie fixes- fix for potential connection leaks in HttpContentEncoder (which is used by webbit via HttpContentCompressor)- performance degradation in http 1.1[2]Other than upgrading the libraries there would be only a minor change (ie adding `ssl.setCloseOnSSLException(true);` to the pipeline logic)[1] 3.5.6 is not recommended, so that leaves 3.5.5, here is the release info: http://netty.io/news/2012/08/22/3-5-5-final.html
[2] https://github.com/netty/netty/issues/476I can put together a PR if needed. Thoughts?
On Wednesday, 24 April 2013 at 14:42, peter hausel wrote:
Now that it looks like the problematic netty version is 3.5.7, would not make sense to upgrade to 3.5.5[1] at least?from 3.5.3 to 3.5.5 there were quite a few important fixes:- fix for connection leaks in SSL handler (when throwing exceptions)- cookie fixes- fix for potential connection leaks in HttpContentEncoder (which is used by webbit via HttpContentCompressor)- performance degradation in http 1.1[2]Other than upgrading the libraries there would be only a minor change (ie adding `ssl.setCloseOnSSLException(true);` to the pipeline logic)[1] 3.5.6 is not recommended, so that leaves 3.5.5, here is the release info: http://netty.io/news/2012/08/22/3-5-5-final.html
[2] https://github.com/netty/netty/issues/476I can put together a PR if needed. Thoughts?Please do - I think that makes sense.