Why query != same_query?

[Alan Etkin]

I have noticed this behavior in trunk. Is this a feature?

>>> q = db.auth_user.id > 0
>>> q2 = db.auth_user.id > 0
>>> q == q2
False

I hope I didn't post a read the manual question again, but doesn't seem to be documented in the DAL section.

Thanks

[Alan Etkin]

I have noticed this behavior in trunk. Is this a feature?

I belive I found the problem: the Query class doesn't implement __eq__ nor __ne__. Is that the cause?

[Anthony]

According to the Python documentation:

If no __cmp__(), __eq__() or __ne__() operation is defined, class instances are compared by object identity (“address”).

The Query class doesn't define any of those operations, so object identity will be used, hence the False value (i.e., each query is a separate object with a separate identity). Instead, you can do:

repr(q) == repr(q2)

Anthony

[Anthony]

repr(q) == repr(q2)

I suppose we could implement __eq__() and __ne__() methods that do the above.

 

Anthony

[Alan Etkin]

repr(q) == repr(q2)

+1 for the repr comparison, as long as it's backwards compatible and it doesn't have conflicts with other query operations

[Massimo Di Pierro]

Good idea Anthony, can you send me a patch?

[Alan Etkin]

Good idea Anthony, can you send me a patch?

I added Anthony's patch to issue 1310. Is it ok?