response.models_to_run in web2py 2.8.2

[rochacbruno]

Hi,

I use web2admin in some applications, I was running older version of web2py and them I decided to upgrade to 2.8.2 for testing.

I found an issue with response.models_to_run and reported a ticket in web2admin repo: https://github.com/rif/web2admin/issues/9

web2admin uses a conditional model running implemented as:

if request.controller == 'web2admin':
    request.controller = 'plugin_web2admin'
    response.view = response.view.replace('web2admin', 'plugin_web2admin')
    response.models_to_run.append("^plugin_web2admin/\w+\.py")

This is used to get rid of "plugin" prefix in urls, so users can access using /welcome/web2admin instead of /welcome/plugin_web2admin (which is a bit ugly)

That practice of checking request.controller and change response.view and response.controller and models_to_run worked very well until version "2.2.1"

Is that changed?

Thanks.

-- 

Bruno Rocha - @rochacbruno

http://github.com/rochacbruno

http://brunorocha.org

http://pythonhub.com

[rochacbruno]

If somebody can help ans test it there is an live app here:

https://web2admin.pythonanywhere.com/admin

password: 35c15f36

error: https://web2admin.pythonanywhere.com/welcome/web2admin

ticket: https://web2admin.pythonanywhere.com/admin/default/ticket/welcome/177.189.155.195.2013-12-20.11-35-10.50855933-8c61-4d91-b1d2-e765a803f698

But if url is changed it works:

https://web2admin.pythonanywhere.com/welcome/plugin_web2admin/index

user: ad...@example.com

password: admin

note that the problem only occurs  when using the shortcut 'web2admin' instead of 'plugin_web2admin'

[Paolo Valleri]

I am not able to debug it a little more but as you can see here: https://github.com/web2py/web2py/commits/master/gluon/compileapp.py

a few changes have been made on how models are handled, perhaps something broken backward compatibility ?

Have you already tried with 2.7.4 ?

Paolo

[Anthony]

I have identified the problem and sent a patch to Massimo (attached). In the meantime, it should work if you change:

    response.models_to_run.append(...)

to:

    response.models_to_run = [...]

When mutating response.models_to_run, it doesn't recognize that it has changed, so you need to do a new assignment instead.

Anthony

[Massimo Di Pierro]

Thanks. It is in trunk!