I just made a few changes to pydal's DB2 adapter. What now?

24 views
Skip to first unread message

Maurizio Brilli

unread,
Mar 17, 2020, 11:42:18 AM3/17/20
to web2py-developers
Hi everybody!

Sorry if I'm being intrusive, but I'm at my first contribution to a github project, so I would like to know if I am doing things properly.

I just did a pull request about the DB2 adapter. The three little changes to the code allowed me to host the web2py auth tables in a DB2 for i database, which I never could do before, because of problems partially depending on the odbc driver, partially on these little bugs. So far I had to keep the auth tables in a separate sqlite db, so you can imagine how happy I am now that all the tables can live in the same environment...

What now? If the pull request is approved, how long does it take to have the pip package updated? I'm asking because I'm starting to work on the migration of our applications from web2py to py4web, and I'd like to use standard methods.

In case it takes long, of course, I'll replace the db2.py file with the patched version and move on...

Thank you for your work, it's been a pleasure working on this project since I discovered web2py...

Best regards.

Maurizio

Reply all
Reply to author
Forward
0 new messages