clearfix class added

12 views
Skip to first unread message

Andrea Franz

unread,
Jan 3, 2010, 8:42:24 PM1/3/10
to web-app-the...@googlegroups.com
I've just removed all the useless div's with the "clear" class to have
a better html code, and I added the wat-cf (wep-app-theme clearfix)
class, that implements the clearfix hack.
If you want to update your stylesheets you have to update all the
generated html as well.

--
Andrea Franz
http://gravityblast.com

lgs

unread,
Jan 5, 2010, 4:11:33 AM1/5/10
to web-app-theme-generator

Hi & happy new year at first, glad to see this forun come to life.

About your changes, do you think they'll fix the small issue I found
about IE6 (see issue n.6: http://github.com/pilu/web-app-theme/issues/#issue/6)

They consists in two minors layout fails:

1) doesn't display margins/borders/paddings as Firefox 3.5.6 actually
do for <div id="main-navigation"> and for <div class="secondary-
navigation">
2) doesn't display -moz-border-radius and the corners are not rounded
in Internet Explorer 6

Please open http://pilu.github.com/web-app-theme/ into Firefox 3.5.6,
and another one into IE7 and compare each other to see what I'm
saying.

Thanks in advance
luca

Andrea Franz

unread,
Jan 5, 2010, 5:53:34 AM1/5/10
to web-app-the...@googlegroups.com
Hi Luca

> 1) doesn't display margins/borders/paddings as Firefox 3.5.6 actually
> do for <div id="main-navigation"> and for <div class="secondary-
> navigation">

I'll check it asap!

> 2) doesn't display -moz-border-radius and the corners are not rounded
> in Internet Explorer 6

rounded corner are built using styles only for safari and firefox.
If we add images for IE we will not use those styles anymore, and
we'll need more html just to create corners.
Do you think it's necessary?

lgs

unread,
Jan 5, 2010, 6:20:53 AM1/5/10
to web-app-theme-generator

> rounded corner are built using styles only for safari and firefox.
> If we add images for IE we will not use those styles anymore, and
> we'll need more html just to create corners.
> Do you think it's necessary?

Well, not really necessary. My clients distribution is actually like
that:

Browser Visits
-----------------------------------------
Firefox 82.65%
Safari 9.18%
Internet Explorer 5.10%
Chrome 2.04%
Mozilla 1.03%

in the future I think it will move up for Safari as well as Chrome &
Mozzilla. Do you know how does it works on the last two ?

bye luca

Andrea Franz

unread,
Jan 5, 2010, 7:29:36 AM1/5/10
to web-app-the...@googlegroups.com
I found the following bugs on IE:

* IE6: user navigation (profile, settings, logout) is not aligned.
actually is at the bottom of the page
* IE6: has different padding on sidebar links and table rows
* ALL IE: avatar/text on lists are not aligned

Do you see any other bugs?

> -----------------------------------------
> Firefox                    82.65%
> Safari                       9.18%
> Internet Explorer        5.10%
> Chrome                    2.04%
> Mozilla                     1.03%
>
> in the future I think it will move up for Safari as well as Chrome &
> Mozzilla. Do you know how does it works on the last two ?

chrome displays the page like FF and safari, I didn't try mozilla but
I think it's the same of FF.

lgs

unread,
Jan 5, 2010, 8:34:46 AM1/5/10
to web-app-theme-generator

> Do you see any other bugs?

No, that's all I can see.

> chrome displays the page like FF and safari, I didn't try mozilla but
> I think it's the same of FF.

That's fine.

Many thanks
bye luca

Reply all
Reply to author
Forward
0 new messages