Re: Jim Mertens just confirmed Shaker Heights 2016

[James Mertens]

Heyo jfly, see below. Possible bug.

On Sun, Jan 24, 2016 at 12:39 PM, Olivér Perge <perge...@gmail.com> wrote:

I definitely did not change it, weird!

2016-01-24 18:22 GMT+01:00 James Mertens <jbc...@gmail.com>:

Although, where did you get that link from? It seems to be missing the "ohio" bit, compared to:

https://www.worldcubeassociation.org/posts/shaker-heights-2016-on-february-20-2016-in-shaker-heights-ohio-usa

If this is a software/website issue, we should pass along.

On Sun, Jan 24, 2016 at 12:19 PM, James Mertens <jbc...@gmail.com> wrote:

Thanks, Oliver :)

On Sun, Jan 24, 2016 at 7:38 AM, Olivér Perge <perge...@gmail.com> wrote:

Announced: https://www.worldcubeassociation.org/posts/shaker-heights-2016-on-february-20-2016-in-shaker-heights-usa

[Jeremy Fleischman]

Wow, I was born in Shaker Heights!

I see Olivér (user id 16) posting the competition announcement here:

~/worldcubeassociation.org/WcaOnRails/log @production> reset && grep -C 20 "shaker-heights-2016-on-february-20-2016-in-shaker-heights-usa" production.log

...

I, [2016-01-24T12:43:54.518810 #3592]  INFO -- : Started GET "/competitions/ShakerHeights2016/post/announcement" for 213.222.165.69 at 2016-01-24 12:43:54 +0000

D, [2016-01-24T12:43:54.520521 #3592] DEBUG -- :   User Load (0.3ms)  SELECT  `users`.* FROM `users` WHERE `users`.`id` = 16  ORDER BY `users`.`id` ASC LIMIT 1

I, [2016-01-24T12:43:54.521794 #3592]  INFO -- : Processing by CompetitionsController#post_announcement as HTML

I, [2016-01-24T12:43:54.521839 #3592]  INFO -- :   Parameters: {"id"=>"ShakerHeights2016"}

D, [2016-01-24T12:43:54.522645 #3592] DEBUG -- :   Competition Load (0.2ms)  SELECT  `Competitions`.* FROM `Competitions` WHERE `Competitions`.`id` = 'ShakerHeights2016' LIMIT 1

D, [2016-01-24T12:43:54.523977 #3592] DEBUG -- :    (0.1ms)  BEGIN

D, [2016-01-24T12:43:54.536245 #3592] DEBUG -- :   Post Exists (1.6ms)  SELECT  1 AS one FROM `posts` WHERE `posts`.`title` = BINARY 'Shaker Heights 2016 on February 20, 2016 in Shaker Heights, USA' LIMIT 1

D, [2016-01-24T12:43:54.537051 #3592] DEBUG -- :   Post Exists (0.2ms)  SELECT  1 AS one FROM `posts` WHERE `posts`.`slug` = BINARY 'shaker-heights-2016-on-february-20-2016-in-shaker-heights-usa' LIMIT 1

D, [2016-01-24T12:43:54.539785 #3592] DEBUG -- :   SQL (1.7ms)  INSERT INTO `posts` (`title`, `body`, `author_id`, `world_readable`, `slug`, `created_at`, `updated_at`) VALUES ('Shaker Heights 2016 on February 20, 2016 in Shaker Heights, USA', 'The [Shaker Heights 2016](https://www.worldcubeassociation.org/results/c.php?i=ShakerHeights2016) will take place on February 20, 2016 in Shaker Heights, USA. Check out the [Shaker Heights 2016 website](http://www.cubingusa.com/shaker2016/) for more information and registration.', 16, 1, 'shaker-heights-2016-on-february-20-2016-in-shaker-heights-usa', '2016-01-24 12:43:54', '2016-01-24 12:43:54')

D, [2016-01-24T12:43:54.545617 #3592] DEBUG -- :    (5.4ms)  COMMIT

I, [2016-01-24T12:43:54.545964 #3592]  INFO -- : Redirected to https://www.worldcubeassociation.org/posts/shaker-heights-2016-on-february-20-2016-in-shaker-heights-usa

I, [2016-01-24T12:43:54.546093 #3592]  INFO -- : Completed 302 Found in 24ms (ActiveRecord: 9.2ms)

I, [2016-01-24T12:43:54.546478 #3592]  INFO -- : [User Id] Request was made by user id: 16

I then see Evan Liu (user id 15) tweaking the post about 1 hour later:

I, [2016-01-24T13:56:11.842769 #3592]  INFO -- : Started PATCH "/posts/5296" for 37.203.169.179 at 2016-01-24 13:56:11 +0000

D, [2016-01-24T13:56:11.844471 #3592] DEBUG -- :   ^[[1m^[[36mUser Load (0.3ms)^[[0m  ^[[1mSELECT  `users`.* FROM `users` WHERE `users`.`id` = 15  ORDER BY `users`.`id` ASC LIMIT 1^[[0m

I, [2016-01-24T13:56:11.845968 #3592]  INFO -- : Processing by PostsController#update as HTML

I, [2016-01-24T13:56:11.846037 #3592]  INFO -- :   Parameters: {"utf8"=>"✓", "authenticity_token"=>"[FILTERED]", "post"=>{"title"=>"Shaker Heights 2016 on February 20, 2016 in Shaker Heights, Ohio, USA", "body"=>"The [Shaker Heights 2016](https://www.worldcubeassociation.org/results/c.php?i=ShakerHeights2016) will take place on February 20, 2016 in Shaker Heights, Ohio, USA. Check out the [Shaker Heights 2016 website](http://www.cubingusa.com/shaker2016/) for more information and registration.", "sticky"=>"0"}, "commit"=>"Update Post", "id"=>"5296"}

D, [2016-01-24T13:56:11.847178 #3592] DEBUG -- :   ^[[1m^[[35mPost Load (0.3ms)^[[0m  SELECT  `posts`.* FROM `posts` WHERE `posts`.`slug` = '5296' LIMIT 1

D, [2016-01-24T13:56:11.848144 #3592] DEBUG -- :   ^[[1m^[[36mPost Load (0.7ms)^[[0m  ^[[1mSELECT  `posts`.* FROM `posts` WHERE `posts`.`id` = 5296 LIMIT 1^[[0m

D, [2016-01-24T13:56:11.848715 #3592] DEBUG -- :   ^[[1m^[[35m (0.1ms)^[[0m  BEGIN

D, [2016-01-24T13:56:11.877100 #3592] DEBUG -- :   ^[[1m^[[36mPost Exists (26.6ms)^[[0m  ^[[1mSELECT  1 AS one FROM `posts` WHERE (`posts`.`title` = BINARY 'Shaker Heights 2016 on February 20, 2016 in Shaker Heights, Ohio, USA' AND `posts`.`id` != 5296) LIMIT 1^[[0m

D, [2016-01-24T13:56:11.878633 #3592] DEBUG -- :   ^[[1m^[[35mPost Exists (0.2ms)^[[0m  SELECT  1 AS one FROM `posts` WHERE (`posts`.`slug` = BINARY 'shaker-heights-2016-on-february-20-2016-in-shaker-heights-ohio-usa' AND `posts`.`id` != 5296) LIMIT 1

D, [2016-01-24T13:56:11.880140 #3592] DEBUG -- :   ^[[1m^[[36mSQL (0.3ms)^[[0m  ^[[1mUPDATE `posts` SET `title` = 'Shaker Heights 2016 on February 20, 2016 in Shaker Heights, Ohio, USA', `body` = 'The [Shaker Heights 2016](https://www.worldcubeassociation.org/results/c.php?i=ShakerHeights2016) will take place on February 20, 2016 in Shaker Heights, Ohio, USA. Check out the [Shaker Heights 2016 website](http://www.cubingusa.com/shaker2016/) for more information and registration.', `slug` = 'shaker-heights-2016-on-february-20-2016-in-shaker-heights-ohio-usa', `updated_at` = '2016-01-24 13:56:11' WHERE `posts`.`id` = 5296^[[0m

D, [2016-01-24T13:56:11.892108 #3592] DEBUG -- :   ^[[1m^[[35m (11.5ms)^[[0m  COMMIT

I, [2016-01-24T13:56:11.892536 #3592]  INFO -- : Redirected to https://www.worldcubeassociation.org/posts/shaker-heights-2016-on-february-20-2016-in-shaker-heights-ohio-usa

I, [2016-01-24T13:56:11.892667 #3592]  INFO -- : Completed 302 Found in 47ms (ActiveRecord: 39.7ms)

I, [2016-01-24T13:56:11.893089 #3592]  INFO -- : [User Id] Request was made by user id: 15

Evan, it's great that you fixed this, but it's very important to overcommunicate when working on the WCA website. Even benign appearing changes can have unexpected consequences =) I'm guilty of failing to overcommunicate myself, but it's something I'm always working on.

This finger pointing would not have been possible without the work of our resident Rails expert, Tim Habermaas, who introduced this "Request was made by user id" log message just 3 days ago in this pull request: https://github.com/cubing/worldcubeassociation.org/pull/341. Thanks Tim!!

-Jeremy

--

---
You received this message because you are subscribed to the Google Groups "software at worldcubeassociation.org" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wca-software...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/wca-software/CAE9q5rkfaohcqPNa082Ai%2BWOkJ-uijV%3DcyxRU%2BK2bEPPwUiU4A%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[Olivér Perge]

Thank you Jeremy for the investigation! :) I was hoping it was not a bug, and I am glad it was fixed. Is it common that the state is missing from the announcement, and should it be fixed in any way?

[Jeremy Fleischman]

It's a common mistake for US competitions. As a board member, Tim Reynolds was very good about enforcing it. Maybe Evan has taken up the mantle? I certainly haven't been keeping my eye on it.

[Olivér Perge]

Well, the 4 of us should be able to spot this before announcing. :) So, basically the city should have state next to it, right?

[Jeremy Fleischman]

Evan or Tim, please correct me, but I'm pretty sure the recommended format for the cityName field for US competitions is "City, State", where State is the full state name. Some examples below. Just for pedantic completeness, this is the "City name" text box on pages like this: https://www.worldcubeassociation.org/competitions/BigAppleCubeClash2016/edit/admin.

SQL query: select id, cityName from Competitions where Competitions.countryId="USA" LIMIT 0, 25 ;
Rows: 25

id	cityName
AllianceForEducation2015	San Bernardino, California
AlpharettaOpen2016	Milton, Georgia
AnotherFMC2015	Ann Arbor, Michigan
AntelopeValleyFall2013	Palmdale, California
AntelopeValleyFall2014	Palmdale, California
AntelopeValleySpring2013	Palmdale, California
AntelopeValleySummer2012	Palmdale, California
AntelopeValleyWinter2013	Palmdale, California
Appalachia2011	Clarksburg, West Virginia
Appalachia2012	Clarksburg, West Virginia
ArizonaOpen2011	Phoenix, Arizona
ArizonaShowdown2011	Glendale, Arizona
ArizonaWinter2012	Phoenix, Arizona
ArmonkSpring2008	Armonk, New York
AthensFall2015	Athens, Georgia
AthensSpring2016	Athens, Georgia
AthensWinterMystery2015	Athens, Georgia
Atlanta2015	Atlanta, Georgia
AuroraSummer2009	Aurora, Colorado
AustinCubingLimits2015	Austin, Texas
AustinFall2009	Austin, Texas
AustinOpen2008	Austin, Texas
AustinSpring2009	Austin, Texas
AZCubingFall2015	Chandler, Arizona
AZCubingWinter2016	Mesa, Arizona

[ILKYOO CHOI]

Can we actually implement this in the code somehow?

— ILKYOO

You received this message because you are subscribed to the Google Groups "board-wca" group.
To unsubscribe from this group and stop receiving emails from it, send an email to board-wca+...@googlegroups.com.
To post to this group, send email to boar...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/board-wca/CAHpv4cOO-QJmbDwddaPGYX0Zcg4u3%3D3PPsabXyG7cgGA7r_tWg%40mail.gmail.com.

[Evan Liu]

Yeah, that's the recommended format. I tend to notice pretty easily when the state is missing. I'll make sure to report it the next time I make such a change!

[Jeremy Fleischman]

Great, thanks! At the very least, if you don't tell people when they screw up, they're not going to know to do a better job next time :).