FYI, scary database schema change coming up

38 views
Skip to first unread message

Jeremy Fleischman

unread,
Apr 3, 2017, 7:00:48 PM4/3/17
to soft...@worldcubeassociation.org, results, softwar...@worldcubeassociation.org
Please see pending PR1492. This PR renames the Rounds table to RoundTypes, which is not a name I particularly like, but is much better than Rounds.

This rename paves way for a later change where we will introduce a proper Rounds table which will contain information about the rounds of competitions. I have not created a PR for that yet, but you can see the preliminary work going on here.

Unless anyone sees an issue with PR1492, I plan to merge and deploy it tomorrow when I wake up.

-Jeremy

Jeff Plumb

unread,
Apr 4, 2017, 12:20:04 AM4/4/17
to Jeremy Fleischman, soft...@worldcubeassociation.org, results, softwar...@worldcubeassociation.org
Looks like a good change to me!

Cheers,
Jeff.

--
You received this message because you are subscribed to the Google Groups "admin at worldcubeassociation.org" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wca-admin+unsubscribe@googlegroups.com.
To post to this group, send email to wca-...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/wca-admin/CAHpv4cMzf%2Bh96NAteHLc1dxpf4BORkrWrWd%2Be1j0zE%3DbiAOLVA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Sébastien Auroux

unread,
Apr 4, 2017, 3:50:22 AM4/4/17
to Jeff Plumb, Jeremy Fleischman, soft...@worldcubeassociation.org, results, softwar...@worldcubeassociation.org
Looks like a a change with a terrible gain/work ratio to me. :P

I also agree with the "scary" part. Let's just hope that nothing breaks.

Jeremy Fleischman

unread,
Apr 4, 2017, 12:59:04 PM4/4/17
to Sébastien Auroux, Jeff Plumb, soft...@worldcubeassociation.org, results, softwar...@worldcubeassociation.org
Ok, merged, deployed, and migration run! Let me know if anything looks broken.
Reply all
Reply to author
Forward
0 new messages