Pull request: Change the layout of digests, Integrate search box and post icon into the top bar and

11 views
Skip to first unread message

Peter Warrington

unread,
Jun 11, 2018, 1:24:56 PM6/11/18
to Wave Protocol

See pull request at: https://github.com/wave-protocol/wave/pull/2


Hello! Sorry for not being extremely active on this project, however these are the changes I have made.

  • Changed layout of digests so that content is to the left and the avatars (That are now circular) are now to the right.

  • Integrated the search box and post icon into the top bar.

Image showing main wave web app

  • And I have revamped the sign in page putting the sign in box into a seperate dialog.

Image showing sign in page without sign in dialog visible
Image showing sign in page with sign in dialog visible

Note: No work has been done yet on the registration page.

Zachary Yaro

unread,
Jun 11, 2018, 5:43:18 PM6/11/18
to sothis...@gmail.com, wave-p...@googlegroups.com
Personally, I disapprove of these changes.  I think keeping the search box inside the search panel is important because it makes it clear where search results will appear, and it leaves open the possibility of having multiple search panels open in some future variant of the client.

For the sign in page, why hide the sign in form behind an extra button press?  It just means you have to wait even longer to sign in.

Zachary Yaro


--
You received this message because you are subscribed to the Google Groups "Wave Protocol" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wave-protoco...@googlegroups.com.
To post to this group, send email to wave-p...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/wave-protocol/194d8224-6f90-4838-94fe-58eb210663b2%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Yuri Zelikov

unread,
Jun 12, 2018, 3:11:33 AM6/12/18
to Wave Protocol
The original sign in page was made similar to an old Gmail login with an attempt to keep the login page minimalistic and simple.

Peter Warrington

unread,
Jun 13, 2018, 2:50:45 PM6/13/18
to Wave Protocol
For the sign-in page, Does this look any better?

Peter Warrington

unread,
Jun 13, 2018, 3:15:31 PM6/13/18
to Wave Protocol


On Monday, June 11, 2018 at 7:24:56 PM UTC+2, Peter Warrington wrote:
Capture5.PNG

Zachary Yaro

unread,
Jun 13, 2018, 3:49:27 PM6/13/18
to Peter Warrington, wave-p...@googlegroups.com
It is better to not have the extra button press, but you made the WIAB screenshot smaller.  I am still not sure any of these variants are better than the current layout.

Zachary Yaro


--
You received this message because you are subscribed to the Google Groups "Wave Protocol" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wave-protoco...@googlegroups.com.
To post to this group, send email to wave-p...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages