Re: Adds attachments support: servlet and UI.

6 views
Skip to first unread message

vruiz....@gmail.com

unread,
Oct 18, 2011, 10:25:36 PM10/18/11
to veg...@gmail.com, soren...@gmail.com, hear...@google.com, michael....@gmail.com, wave-protocol...@googlegroups.com
On 2011/10/08 14:37:47, Michael wrote:
> Sorry, I thought I had replied to this again. LGTM.
> On 2011/10/08 13:47:45, vjrj wrote:
> > ping

Any other comment? Can be commit?

Thanks,


http://codereview.waveprotocol.org/616002

veg...@gmail.com

unread,
Oct 19, 2011, 3:40:03 AM10/19/11
to soren...@gmail.com, hear...@google.com, michael....@gmail.com, vruiz....@gmail.com, wave-protocol...@googlegroups.com
On 2011/10/19 02:25:36, vjrj wrote:
> On 2011/10/08 14:37:47, Michael wrote:
> > Sorry, I thought I had replied to this again. LGTM.
> > On 2011/10/08 13:47:45, vjrj wrote:
> > > ping

> Any other comment? Can be commit?

> Thanks,

I think Michael gave his LGTM, so I ll commit the patch soon. By the way
Vicente, can you review the patch as well? I ll send you the binary
files.

http://codereview.waveprotocol.org/616002

vruiz....@gmail.com

unread,
Oct 20, 2011, 2:29:36 PM10/20/11
to veg...@gmail.com, soren...@gmail.com, hear...@google.com, michael....@gmail.com, wave-protocol...@googlegroups.com
LGTM.

Good job Yuri...


http://codereview.waveprotocol.org/616002

veg...@gmail.com

unread,
Oct 21, 2011, 10:34:17 AM10/21/11
to soren...@gmail.com, hear...@google.com, michael....@gmail.com, vruiz....@gmail.com, wave-protocol...@googlegroups.com
Committed revision 1187363 to SVN.

http://codereview.waveprotocol.org/616002

Reply all
Reply to author
Forward
0 new messages