Deletes 3.9kloc of obsolete webclient code.

[hear...@google.com]

Reviewers: Yuri Z., tad.glines_gmail.com,

Please review this at http://codereview.waveprotocol.org/537001

Affected files:
M src/org/waveprotocol/box/webclient/WebClient.gwt.xml
R src/org/waveprotocol/box/webclient/client/BlipView.java
R src/org/waveprotocol/box/webclient/client/BlipView.ui.xml
R src/org/waveprotocol/box/webclient/client/CcStackManager.java
R src/org/waveprotocol/box/webclient/client/ClientEventWaveCallback.java
M src/org/waveprotocol/box/webclient/client/ClientEvents.java
M src/org/waveprotocol/box/webclient/client/ClientIdGenerator.java
R src/org/waveprotocol/box/webclient/client/EditorWidget.java
M
src/org/waveprotocol/box/webclient/client/RemoteViewServiceMultiplexer.java
M src/org/waveprotocol/box/webclient/client/RemoteWaveViewService.java
R src/org/waveprotocol/box/webclient/client/SimpleCcDocumentFactory.java
M src/org/waveprotocol/box/webclient/client/SubmitResponseCallback.java
R src/org/waveprotocol/box/webclient/client/WaveView.java
R src/org/waveprotocol/box/webclient/client/WaveView.ui.xml
M src/org/waveprotocol/box/webclient/client/WaveWebSocketClient.java
M src/org/waveprotocol/box/webclient/client/WebClient.java
R src/org/waveprotocol/box/webclient/client/events/UserLoginEvent.java
R
src/org/waveprotocol/box/webclient/client/events/UserLoginEventHandler.java
R
src/org/waveprotocol/box/webclient/client/events/WaveIndexUpdatedEvent.java
R
src/org/waveprotocol/box/webclient/client/events/WaveIndexUpdatedEventHandler.java
M src/org/waveprotocol/box/webclient/client/events/WaveOpenEvent.java
M
src/org/waveprotocol/box/webclient/client/events/WaveOpenEventHandler.java
M
src/org/waveprotocol/box/webclient/client/events/WaveSelectionEventHandler.java
R src/org/waveprotocol/box/webclient/client/events/WaveUpdatedEvent.java
R
src/org/waveprotocol/box/webclient/client/events/WaveUpdatedEventHandler.java
R src/org/waveprotocol/box/webclient/client/events/WaveletBlipEvent.java
R
src/org/waveprotocol/box/webclient/client/events/WaveletBlipEventHandler.java
R src/org/waveprotocol/box/webclient/client/wavelist/CellList.css
R src/org/waveprotocol/box/webclient/client/wavelist/RangeLabelPager.java
R
src/org/waveprotocol/box/webclient/client/wavelist/ShowMorePagerPanel.java
R src/org/waveprotocol/box/webclient/client/wavelist/WaveListPanel.css
R src/org/waveprotocol/box/webclient/client/wavelist/WaveListPanel.java
R src/org/waveprotocol/box/webclient/client/wavelist/WaveListPanel.ui.xml
R src/org/waveprotocol/box/webclient/client/wavelist/images/panel_e.png
R src/org/waveprotocol/box/webclient/client/wavelist/images/panel_n.png
R src/org/waveprotocol/box/webclient/client/wavelist/images/panel_ne.png
R src/org/waveprotocol/box/webclient/client/wavelist/images/panel_nw.png
R src/org/waveprotocol/box/webclient/client/wavelist/images/panel_s.png
R src/org/waveprotocol/box/webclient/client/wavelist/images/panel_se.png
R src/org/waveprotocol/box/webclient/client/wavelist/images/panel_sw.png
R src/org/waveprotocol/box/webclient/client/wavelist/images/panel_w.png
R
src/org/waveprotocol/box/webclient/client/wavelist/images/toolbar_empty.png
R
src/org/waveprotocol/box/webclient/common/communication/callback/ExceptionHandlingStreamingRemoteCallback.java
M src/org/waveprotocol/box/webclient/search/Search.java
R src/org/waveprotocol/box/webclient/waveclient/common/Common.gwt.xml
R
src/org/waveprotocol/box/webclient/waveclient/common/WaveViewServiceImpl.java
R
src/org/waveprotocol/box/webclient/waveclient/common/WebClientBackend.java
R src/org/waveprotocol/box/webclient/waveclient/common/WebClientUtils.java
R
src/org/waveprotocol/box/webclient/waveclient/common/WebClientWaveView.java
R
src/org/waveprotocol/box/webclient/waveclient/common/WebClientWaveViewUpdate.java

[Tad.G...@gmail.com]

This doesn't compile. SubmitResponseCallback package was changed, but
the file wasn't moved to the new path location. It's import was also
removed from several files that still need it. This is true for
ClientIDGenerator and possibly others.

http://codereview.waveprotocol.org/537001

[hear...@google.com]

Ah, the problem must be with the codereview tool and/or hg moves. When
I applied that patch to a clean checkout, the moved files don't actually
get moved - their package lines just get edited, like you say. It
builds fine in my hg client.

I've uploaded a new patch where the hg diff is all adds and removes, no
moves. I've verified that applying this patch to a clean checkout now
produces the correct state, and it compiles.

Regarding the moved files: after deleting the obsolete files, the only
contents remaining in the webclient/waveclient/common package were
ClientIdGenerator and SubmitResponseCallback. In this patch I've moved
them, for the following reasons. Those two classes are completely
unrelated, they're not important enough to have their own packages, and
webclient/waveclient/common is an awful package name. I just moved each
file to the same package where all references to it occur (callers,
instantiators, and implementers are all in the same package), and same
for ClientIdGenerator, emptying the webclient/waveclient package.

I think it would be a good idea to create a communication package in the
webclient, where the implementation of the client/server wave
communication protocol lives. Currently it just sits in webclient,
across ~5 classes. But I didn't want to do that bigger move within in
this patch.

http://codereview.waveprotocol.org/537001/diff/1/13
File
src/org/waveprotocol/box/webclient/client/SubmitResponseCallback.java
(right):

http://codereview.waveprotocol.org/537001/diff/1/13#newcode17
Line 17: package org.waveprotocol.box.webclient.client;
SubmitResponseCallback now lives here.

http://codereview.waveprotocol.org/537001

[veg...@gmail.com]

LGTM. Nice work David!

http://codereview.waveprotocol.org/537001

[ano...@google.com]

<3

http://codereview.waveprotocol.org/537001