Re: Adds auto focusing on the oldest unread/newest modified blip when opening a wave.
veg...@gmail.com
> http://codereview.waveprotocol.org/610001/diff/15001/13002
> File src/org/waveprotocol/box/webclient/client/StageTwoProvider.java
(right):
> http://codereview.waveprotocol.org/610001/diff/15001/13002#newcode75
> Line 75: Preconditions.checkArgument(waveRef.getWaveId() != null);
> On 2011/09/02 08:19:29, hearnden wrote:
> > I'm not sure this is a requirement of waverefs.
> The waveRef should at least contain the id of the wave to load. It can
> potentially contain also a blip id, in such case it would be the blip
that will
> receive the focus.
> http://codereview.waveprotocol.org/610001/diff/15001/13002#newcode144
> Line 144: selectAndFocusOnBlip(reader);
> On 2011/09/02 08:19:29, hearnden wrote:
> > Please move this up a few lines. The whenReady callback should be
called only
> > once the stage, and everything it set up, is finished loading.
> The blip should be already rendered so it will be possible to focus on
it.
> http://codereview.waveprotocol.org/610001/diff/15001/13004
> File src/org/waveprotocol/wave/client/StageTwo.java (right):
> http://codereview.waveprotocol.org/610001/diff/15001/13004#newcode713
> Line 713: protected Reader installReader() {
> On 2011/09/02 08:19:29, hearnden wrote:
> > Can the changes in this file be reverted? It looks like they have
no effect.
> The returned reader is used in StageTwoProvider, line 144.
> http://codereview.waveprotocol.org/610001/diff/15001/13005
> File
src/org/waveprotocol/wave/client/wavepanel/impl/focus/FocusBlipSelector.java
> (right):
> http://codereview.waveprotocol.org/610001/diff/15001/13005#newcode53
> Line 53: private Reader reader = null;
> On 2011/09/02 08:19:29, hearnden wrote:
> > remove the null, and Eclipse should then auto-finalize this field.
> Done.
> http://codereview.waveprotocol.org/610001/diff/15001/13005#newcode87
> Line 87: * modified blip.</li>
> On 2011/09/02 08:19:29, hearnden wrote:
> > </ul>
> Done.
ping