Re: Evicts persisted deltas from memory (Incomplete).

[veg...@gmail.com]

Pushed new patch set. I reverted all previous changes and started from
scratch, trying to keep things as simple as possible. Also updated tests
to make them pass. I tried to run the server and it makes impression
like it works correctly.

http://codereview.waveprotocol.org/615001

[veg...@gmail.com]

Self review.

http://codereview.waveprotocol.org/615001/diff/23001/24002
File
src/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletState.java
(right):

http://codereview.waveprotocol.org/615001/diff/23001/24002#newcode491
Line 491:
Remove space.

http://codereview.waveprotocol.org/615001/diff/23001/24004
File
src/org/waveprotocol/box/server/waveserver/LocalWaveletContainerImpl.java
(right):

http://codereview.waveprotocol.org/615001/diff/23001/24004#newcode105
Line 105: acquireWriteLock();
Remove this line.

http://codereview.waveprotocol.org/615001/diff/23001/24004#newcode141
Line 141: });
Not sure this is the right executor.

http://codereview.waveprotocol.org/615001/diff/23001/24004#newcode269
Line 269: });
Is this the right executor?

http://codereview.waveprotocol.org/615001/diff/23001/24005
File
src/org/waveprotocol/box/server/waveserver/RemoteWaveletContainerImpl.java
(right):

http://codereview.waveprotocol.org/615001/diff/23001/24005#newcode282
Line 282: // XXX (Yuri Z.) This is blocking call. Should we avoid this?
Remove the comment.

http://codereview.waveprotocol.org/615001/diff/23001/24005#newcode368
Line 368: final SettableFuture<WaveletDeltaRecord> futResult =
SettableFuture.create();
Move semicolon to correct position.

http://codereview.waveprotocol.org/615001/diff/23001/24005#newcode374
Line 374: @Override
Remove line.

http://codereview.waveprotocol.org/615001/diff/23001/24005#newcode377
Line 377: try {
Remove line.

http://codereview.waveprotocol.org/615001/diff/23001/24005#newcode379
Line 379: } catch (InterruptedException e) {
Remove line.

http://codereview.waveprotocol.org/615001/diff/23001/24006
File src/org/waveprotocol/box/server/waveserver/WaveMap.java (right):

http://codereview.waveprotocol.org/615001/diff/23001/24006#newcode1
Line 1: /**
Revert this class since no changes were made.

http://codereview.waveprotocol.org/615001/diff/23001/24007
File src/org/waveprotocol/box/server/waveserver/WaveServerImpl.java
(right):

http://codereview.waveprotocol.org/615001/diff/23001/24007#newcode591
Line 591:
resultListener.onFailure(FederationErrors.internalServerError(e.getMessage()));
Change to
resultListener.onFailure(FederationErrors.internalServerError(e.getCause().getMessage()));

http://codereview.waveprotocol.org/615001/diff/23001/24008
File src/org/waveprotocol/box/server/waveserver/WaveServerModule.java
(right):

http://codereview.waveprotocol.org/615001/diff/23001/24008#newcode71
Line 71:
.newFixedThreadPool(STORAGE_CONTINUATION_EXECUTOR_THREAD_COUNT);
What executors should I use? Also add // TODO to inject these executors.

http://codereview.waveprotocol.org/615001/diff/23001/24010
File
src/org/waveprotocol/box/server/waveserver/WaveletContainerImpl.java
(right):

http://codereview.waveprotocol.org/615001/diff/23001/24010#newcode592
Line 592:
Remove the lines.

http://codereview.waveprotocol.org/615001/diff/23001/24013
File src/org/waveprotocol/wave/federation/WaveletFederationProvider.java
(right):

http://codereview.waveprotocol.org/615001/diff/23001/24013#newcode82
Line 82: * @param domain the domain of the requester, used to determine
whether there
Remove line.

http://codereview.waveprotocol.org/615001/diff/23001/24016
File
test/org/waveprotocol/box/server/waveserver/DeltaStoreBasedWaveletStateTest.java
(right):

http://codereview.waveprotocol.org/615001/diff/23001/24016#newcode47
Line 47: READ_ACCESS_EXECUTOR);
Format this line.

http://codereview.waveprotocol.org/615001/diff/23001/24019
File test/org/waveprotocol/box/server/waveserver/WaveServerTest.java
(right):

http://codereview.waveprotocol.org/615001/diff/23001/24019#newcode110
Line 110: WaveServerModule
Format this line.

http://codereview.waveprotocol.org/615001