Re: Adds auto focusing on the oldest unread/newest modified blip when opening a wave.

[veg...@gmail.com]

On 2011/11/08 18:50:16, Jeremy Ngl wrote:
> Hi all.
> I'm not a coder or a reviewer but just an addicted hardcore GWave and
WIAB user.
> I've ended up on this page after some research because I've used this
"auto
> focus on the oldest unread blip, or newest modified blip when the wave
is read"
> feature on the http://waveinabox.net demo servers for some weeks and I
was impatient of
> seeing it back into WIAB. Without code knowledge I can't debate on the
server or
> client roles nor about optimization, but since there is also some
debate on the
> usefulness of this feature, please allow me to share how I see it as a
user.
> For unread blips this features behaves exactly like on GWave. But when
opening a
> fully read wave, it adds this extra-feature of focusing on the last
edited blip.
> This is brilliant because in a large wave that is read and that hasn't
been
> edited for some time, it can be a pain to track back the final state
of the
> discussion (because of the non-linear structure of the wave) in order
to reply
> where this discussion/debate last stopped (and even if playback was
implemented
> it would be a longer process just to find back the last point made).
> In fact, after only a few opened waves, I was already missing that
feature when
> I was back on GWave. And as Yuri said, the feedback expressed by 10+
> http://waveinabox.net users was extremely positive. I have no idea if
you can
> technically try a patch before submitting it, but I'm almost certain
that if you
> try this feature for a few days you'll adopt it. It's really a "must"
for
> productivity.
> I hope that posting here without being a contributor isn't some kind
of spam and
> I hope this post can be of any help.
> Best regards to you all and thanks for your work on Wave,
> Jeremy.

Unless anyone objects during the next 24 hours I ll submit this patch.
In case there will be comments after submission, they will be addressed
in subsequent patches.

http://codereview.waveprotocol.org/610001

[michael....@gmail.com]

LGTM.

[veg...@gmail.com]

Committed as revision 1203614 to Apache SVN

http://codereview.waveprotocol.org/610001