Comment on revision r4851 in wagic

[wa...@googlecode.com]

Comment by omegabla...@gmail.com:

General Comment:
99 - MTGCardInstance * _target = (MTGCardInstance *) target;
100 99 if(!source->controller()->getManaPool()->canAfford(costToPay))
101 100 {
102 101 return 0;
...

this will crash you eventually.
MTGCardInstance * _target = (MTGCardInstance *) target;

set it and forget it unless its giving you a bug now. there was a reason i
did that.

For more information:
https://code.google.com/p/wagic/source/detail?r=4851

[wa...@googlecode.com]

Comment by pank...@gmail.com:

General Comment:

"MTGCardInstance * _target = (MTGCardInstance *) target;"

Could you explain, how will it create a bug?
I can see that "_target" is just a local variable here and is not used
later, so this expression really does nothing and can be removed without
any issues.

[wa...@googlecode.com]

Comment by omegabla...@gmail.com:

General Comment:

Sorry i was looking at a portion of code in my rev where I had used it for
an ability thats not committed. i kind of just drop everything a while back
so I have no clue where I was heading with what I currently have
uncommitted. disregard.