QueryModel disruptive changes

[Luc Boudreau]

Please take note that some disruptive changes will be performed to olap4j's Query Model in order to fix some issues. The changes are the following.

• The QueryDimension.SortOrder and QueryAxis.SortOrder will both be factored out and a single enumeration org.olap4j.query.SortOrder will remain. All relevant method setters and getters will be changed accordingly. We can't use Java's regular deprecation mechanism because of Java's no support for enumeration class heritage.
• QueryDimension.setSortOrder() will be renamed QueryDimension.sort() in order to preserve method names homogeneity.
  
• Including selections by name parts will now throw OlapException when no member corresponding to the supplied name parts can be found. It used to fail silently, but no more.
• SelectionFactory scope will be limited to package level because all necessary methods to create inclusions/exclusions are now encapsulated in QueryDimension.
• CellSetFormatter, TraditionalCellSetFormatter and RectangularCellSetFormatter were moved in the long overdue org.olap4j.layout package. Their old declaration in the org.olap4j.query package will remain there until version 1.0 and was marked as deprecated.
  

I am sorry for any inconvenient caused and will, as always, help anyone with migration issues caused by these new classes tweaks. I will commit these changes sometime this week.

_____________________________
Luc Boudreau

[Jeffrey Mo]

Hmm, should we continue with using the latest snapshot for olap4j after
this change? I'm not sure how much stuff in the Wabit will be broken by
these changes.

-Jeff

Luc Boudreau wrote:
> Please take note that some disruptive changes will be performed to
> olap4j's Query Model in order to fix some issues. The changes are the
> following.
>

> * The QueryDimension.SortOrder and QueryAxis.SortOrder will both

> be factored out and a single enumeration
> org.olap4j.query.SortOrder will remain. All relevant method
> setters and getters will be changed accordingly. We can't use
> Java's regular deprecation mechanism because of Java's no
> support for enumeration class heritage.

> * QueryDimension.setSortOrder() will be renamed

> QueryDimension.sort() in order to preserve method names homogeneity.

> * Including selections by name parts will now throw OlapException

> when no member corresponding to the supplied name parts can be
> found. It used to fail silently, but no more.

> * SelectionFactory scope will be limited to package level because

> all necessary methods to create inclusions/exclusions are now
> encapsulated in QueryDimension.

> * CellSetFormatter, TraditionalCellSetFormatter and

[Jonathan Fuerth]

On Tue, Aug 18, 2009 at 11:58 AM, Jeffrey Mo<jef...@sqlpower.ca> wrote:
>
> Hmm, should we continue with using the latest snapshot for olap4j after
> this change? I'm not sure how much stuff in the Wabit will be broken by
> these changes.

Yes, these look like good changes. I don't think they'll hurt the
Wabit; only help!

-Jonathan

[Luc Boudreau]

The Discussed changes were committed in revision 277 as of now.
_____________________________
Luc Boudreau