Windows user please test "Added support for using externally created window for win32 platform" PR

[Robert Osfield]

Hi All,

We have a VulkanSceneGraph pull request that I need help testing from Windows user with:

    "Added support for using externally created window for win32 platform"

    The PR : https://github.com/vsg-dev/VulkanSceneGraph/pull/543

I have created a branch for this submission:

    https://github.com/vsg-dev/VulkanSceneGraph/tree/deadcast2-master

The first question we need to confirm is that these changes don't affect existing applications/examples under Windows.

The second question is whether it does indeed enable use of externally created Win32 Windows when creating a vsg::Window.

There is some discussion on the above PR on github so have a read of that for more info.

I'd really like to be able to get this PR/branch reviewed and merged with VSG master before I make the VulkanSceneGraph-1.0 and start issuing release candidates.

Thanks in advance,

Robert.

[Rainer Gericke]

Hi All,

I just completed the tests of   https://github.com/vsg-dev/VulkanSceneGraph/tree/deadcast2-master. I didn't find any build problems, the example programs work as expected. The only existing test for the new functionality is the vsgwx example, it also builds and works well.

[Robert Osfield]

On Thu, 3 Nov 2022 at 07:04, Rainer Gericke <dr.ratz...@gmail.com> wrote:

I just completed the tests of   https://github.com/vsg-dev/VulkanSceneGraph/tree/deadcast2-master. I didn't find any build problems, the example programs work as expected. The only existing test for the new functionality is the vsgwx example, it also builds and works well.

That's excellent news, thanks for the testing.

 

[Robert Osfield]

I have merged the "Added support for using externally created window for win32 platform" PR with master.

[ca...@imap.cc]

Awesome! Thanks Robert for the merge and thanks dr.ratz for testing. :)