GitHub Pull Requests

7 views
Skip to first unread message

Todd Furlong

unread,
May 1, 2015, 10:07:41 AM5/1/15
to vrjuggl...@googlegroups.com
First of all, thanks to Carsten for issuing some pull requests to the GitHub repo.  I'm accepting them one by one and trying them out.  I just committed my own code for a VS2013 build as well.

In the past, reviewing code has been Patrick's thing, but to keep it moving I'm thinking a few of us should share the responsibility.  That OK, Patrick?

I'm inclined to let commits into the master branch if they look reasonable.  I'll try them if I can, but I may not always get a chance to.  For larger changes, I'm hoping we can have a discussion on the pull request.

If that's acceptable, then we can move forward with that mindset.

-Todd

Doug McCorkle

unread,
May 1, 2015, 10:12:56 AM5/1/15
to vrjuggl...@googlegroups.com
Sounds good to me. Thanks Todd.

Doug
> --
>
> ---
> You received this message because you are subscribed to the Google Groups "vrjuggler-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to vrjuggler-dev...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Patrick Fewell-Hartling

unread,
May 1, 2015, 11:45:07 AM5/1/15
to vrjuggl...@googlegroups.com
Same here.

Thanks,
Patrick
Reply all
Reply to author
Forward
0 new messages