Issue 50 in vrjuggler: GL3 merge introduced duplicated code

2 views
Skip to first unread message

vrju...@googlecode.com

unread,
Jan 17, 2013, 2:00:32 PM1/17/13
to vrjuggl...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 50 by ryan.pav...@gmail.com: GL3 merge introduced duplicated code
http://code.google.com/p/vrjuggler/issues/detail?id=50

There is some logic as to which header to include to get GL3 which is
duplicated at least in the following files:

/modules/vrjuggler/vrj/Draw/OpenGL/ExtensionLoaderGLCore.cpp
/modules/vrjuggler/vrj/Draw/OpenGL/DrawWandFunctorsCore.cpp
/modules/vrjuggler/vrj/Draw/OpenGL/DrawHeadFunctorsCore.cpp
/modules/vrjuggler/vrj/Draw/OpenGL/DrawAxesFunctorsCore.cpp

Since the comments suggest that this might change in the future, having
this duplicated runs the risk of updating one instance but not another. A
simple header like the one I've attached might be good to include instead,
to centralize this logic. (Preprocessor logic - among my least favorite
kinds - though unavoidable here)

Attachments:
CommonGLInclude.h 1.7 KB

Reply all
Reply to author
Forward
0 new messages