Error listener not cleared in 1.1.0-rc1, finish not clearing error listener.

[Daya Nand]

Hi Team,

I am using volley 1.1.0-rc1 which is resulting in memory leak as in case of request with error, mErrorListener is not cleared.

On exploring i found that com.android.volley.Request#finish method doesn't clears mErrorListener, and doesn't provide any option for custom request to clear its listener.

Same thing was handled in https://github.com/mcxiaoke/android-volley/commit/c111d14699a2235ea5d3af51b40bcf67ba310bf8

by adding onFinish() inside finish, where onFinish cleared mErrorListener. Which will help custom request to clear mListeners.

Currently i am achieving same functionality by adding request finish listener in request queue, but its a hack because to clear mErrorListener i need to call cancel as mErrorListener is private.

[Jeff Davidson]

It looks like you also filed https://github.com/google/volley/issues/114 so we can follow up there.

--
You received this message because you are subscribed to the Google Groups "Volley Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to volley-users+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.