Unused variables: q_obj_reps, a_obj_reps

[Arjun Singh]

Hi, 

I am trying to understand the "forward" method of the model and I came across these two lines of code where the question and answer representations are created using the embed_span method.

I am not able to understand why the q_obj_reps and a_obj_reps variables are not used anywhere ahead in the code. Could you please explain the reason?

# Now get the question representations
q_rep, q_obj_reps = self.embed_span(question, question_tags, question_mask, obj_reps['obj_reps'])
a_rep, a_obj_reps = self.embed_span(answers, answer_tags, answer_mask, obj_reps['obj_reps'])

Link to code: https://github.com/rowanz/r2c/blob/77813d9e335711759c25df79c348a7c2a8275d72/models/multiatt/model.py#L158

Kind regards,

Arjun

[Rowan Zellers]

hi Arjun,

Sorry for the confusion, the object representations are used to contextualize the question/answer respectively. However, the R2C model doesn't use those underlying representations afterwards (so it probably would have been better style for me to leave it out or write

# Now get the question representations

q_rep, _ = self.embed_span(question, question_tags, question_mask, obj_reps['obj_reps'])
a_rep, _ = self.embed_span(answers, answer_tags, answer_mask, obj_reps['obj_reps'])

hope that helps! thanks,

Rowan

[Arjun Singh]

Hi Rowan,

Thank you for your prompt response.

Kind regards,

Arjun