Github?

[Vincent Parrett]

Hi All

Is there any interest from the community in moving this project to Github. 

Thre are a number of benefits to moving to github, but the main one is the ease with which it manages contributions. 

For those not familiar with Github,  contributing on git is a simple as :

1) fork the repository to your account (click the fork button at the top right)

https://help.github.com/articles/fork-a-repo/

2) clone your fork locally. This is important, always work with a clone of your fork unless you own the repo.

github for windows makes this trivial.

https://help.github.com/articles/getting-started-with-github-for-windows/

So does SourceTree. 

3) create a new branch from master (or whatever branch you are wanting to modify). 

This is optional but preferred.

4) make your changes, commit and push your new branch to github 

Note that etiquette suggests that pull requests consist of small focused commits rather than large wholesale changes. This makes it easier to track changes and find regressions.

5) Create a Pull Request on github

https://help.github.com/articles/using-pull-requests/

Github will automatically notify the project owner(s) that a pull request needs their attention. The project owners can then take a look at the diffs, add comment (to the pull request, but also to the code), and then decide whether the merge the pull request. 

There are other benefits to this model, such as being able to perform CI builds on the pull requests, and tell github about the status of the pull request. We do that here with DUnitX and Delphi-Mocks. 

https://www.finalbuilder.com/resources/blogs/postid/700/building-github-pull-requests-with-continua-ci

https://www.finalbuilder.com/resources/blogs/postid/714/updating-github-status-with-build-event-handlers-in-continua-ci-15

Github also tracks Forks (ie clones on github) of a project, so you can take look at what other people are doing with the project. Often when the original project is abandoned (and therefor not accepting pull requests), other users will fork a project and continue developing the project. Looking at forks, it's easy to see where development happening on a code base. 

Another benefit is when you have some changes to the project that you cannot contribute back (perhaps because they were not accepted), with git it's very easy to keep your fork up to date but still keep your own mods in place. 

I realise that some svn users may not be keen to convert to git.. but it's really not that hard. There are goood free tools available for Git. 

Anyway, just putting it out there, I'm happy to help with the migration is there is enough interest.

Regards

Vincent.

[luizamer...@gmail.com]

Em segunda-feira, 19 de janeiro de 2015 00:14:57 UTC-3, Vincent Parrett escreveu:
> Hi All
>
> Is there any interest from the community in moving this project to Github. 

+1

It will make a lot easier to keep the Lazarus fork in sync

BTW i was planning to create my own mirror in Github

Luiz

[luizamer...@gmail.com]

Em segunda-feira, 19 de janeiro de 2015 00:14:57 UTC-3, Vincent Parrett escreveu:

> Hi All
>
> Is there any interest from the community in moving this project to Github. 
>
>

+1

It will make a lot easier to keep the Lazarus fork in sync

BTW i was planning to create my own mirror in Github

Luiz

[Joachim Marder]

Hi.

After receiving mainly positive feedback on Vincent's proposal to move to GitHub, I would like to go this step.

I will announce it later on the the "Latest News" section of the Google Code page later today.

Best regards,

Joachim

--
You received this message because you are subscribed to the Google Groups "Virtual Treeview" group.
To unsubscribe from this group and stop receiving emails from it, send an email to virtual-treevi...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Vincent Parrett]

On 26/01/2015 7:36 PM, Joachim Marder wrote:
> Hi.
>
> After receiving mainly positive feedback on Vincent's proposal to move
> to GitHub, I would like to go this step.
>
> I will announce it later on the the "Latest News" section of the
> Google Code page later today.

You might also want to update the googlecode project page to direct
people to github.. it's quite common to see something like:

"This project has moved to Github -
https://github.com/Virtual-TreeView/Virtual-TreeView"


--
Regards

Vincent Parrett

VSoft Technologies Pty Ltd
https://www.finalbuilder.com
Blog: https://www.finalbuilder.com/resources/blogs
Automate your Software builds with FinalBuilder.

[Joachim Marder]

I'm about to do this right now, I first wanted to move the Wiki pages.
To all other developers: Please send us you GitHub username so that we can add you to the project.

--
You received this message because you are subscribed to the Google Groups "Virtual Treeview" group.

To unsubscribe from this group and stop receiving emails from it, send an email to virtual-treeview+unsubscribe@googlegroups.com.

[Vincent Parrett]

On 27/01/2015 12:11 AM, Joachim Marder wrote:
> I'm about to do this right now, I first wanted to move the Wiki pages.
> To all other developers: Please send us you GitHub username so that we
> can add you to the project.

The cool thing about github is you don't need to give everyone access to
the repo to do anything. Best practice is they work with a fork, and
submit pull requests.

[Joachim Marder]

OK, thanks for clarifying this best practice. It might still look strange for longtime developers of the project if they do not get invited, especially if they are not familiar with GitHub best pratices like me.

I guess everything is done now.

Thanks for your help and best regards,

Joachim

[Vincent Parrett]

On 27/01/2015 10:03 AM, Joachim Marder wrote:
> OK, thanks for clarifying this best practice. It might still look
> strange for longtime developers of the project if they do not get
> invited, especially if they are not familiar with GitHub best pratices
> like me.
>
> I guess everything is done now.
>
> Thanks for your help and best regards,

No problem. I'll be making some pull requests this week with some
refactoring, and then also looking at the vcl theme

[Vincent Parrett]

Hi All

I just submitted a pull request for VT, splitting out as much as I could
without breaking things. I did move some utility function out to
VirtualTrees.Utils, so if people were using them they would have to add
the unit, but my guess is most people would not be using them. As I can
tell everything is still working fine.

https://github.com/Virtual-TreeView/Virtual-TreeView/pull/511

Please review.

[Joachim Marder]

> and then also looking at the vcl theme

What is the exact problem with the VCL theme?

Did you already open an issue for it?

I'm not sure when I find time to look at you pull requests. I usually can spend only a few hours per week on Vt.

Best regards,

Joachim

[Joachim Marder]

I am trying to merge your pull request using Atlassian SourceTree, but it is quite difficult and takes a lot of time. I have a lot of merge conflicts and SourceTree is not interopearting with the external merge tool. So sorry for the delay.

[Joachim Marder]

I now merged your pull request. Do you get a notification from GitHub when I have done so?

[Vincent Parrett]

On 30/01/2015 9:22 AM, Joachim Marder wrote:
> I now merged your pull request. Do you get a notification from GitHub
> when I have done so?

Yes, I did thanks. I just pushed another one.. which will look like it
had lots of changes, I had to fix the line endings because it was
causing issues every time I check out it was marking files as modified
that were not, and I could not get git to discard the files.

The actual change was to fill the bitmaps before firing the event so
they have the correct background.