Virtual TreeView pathc for VCL styles

[Joachim Marder]

Hi fellows.

Yesterday I committed a larger patch that I received from Dietmar Rösler which addresses various issue regarding VCL styles (especially #478 and #491). It would be great if those of you who use VCL styles could test the trunk version of Virtual Treeview in your application to check if the patch has any unwanted side effects.

Thanks and best regards,

Joachim

[Achim Kalwa]

Hello Joachim,

Yesterday I committed a larger patch that I received from Dietmar Rösler which addresses various issue regarding VCL styles (especially #478 and #491). It would be great if those of you who use VCL styles could test the trunk version of Virtual Treeview in your application to check if the patch has any unwanted side effects.

 

Something in the trunk version (6.0.0?) makes the header painting wrong on Windows 7 (both Aero and Basic style). Branch V5.5.2 has the correct painting. Please see attached screenshot image. Left window is using VST V5.5.2, right image is from VST 6.0 (Trunk). I've also attached the small sample project.

There are no special VCL styles applied; just plain VCL Win32 application with Delphi XE7.

Regards,

Achim

[Joachim Marder]

Hello Achim.

I just applied a patch from Dietmar. Did the situation improve for you?

Best regards,

Joachim

--
You received this message because you are subscribed to the Google Groups "Virtual Treeview" group.
To unsubscribe from this group and stop receiving emails from it, send an email to virtual-treevi...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Achim Kalwa]

Hello Joachim,

thank you for the quick response.

Am Dienstag, 11. November 2

 

I just applied a patch from Dietmar. Did the situation improve for you?

The columns itself are now painted correctly; however the remaining part of the header bar is still painted wrong (the "unused" area). Screenshot attached.

Achim

[Joachim Marder]

Hi Achim.

Would you mind testing the latest trunk version again? It now includes a further patch from Dietmar.

Thanks and best regards,

Joachim

--

[Achim Kalwa]

Hello Joachim,

sorry for the delay; I couldn't test over the weekend.

The version from trunk now paints the header correctly on Windows 7 Basic an Areo style; but when closing the application an exception is raised.

I've tracked down the bug to TVTHeader.Destroy; which causes TCollection.Changed() to be called, which in turn calls 

TVirtualTreeColumn.Update -> TVirtualTreeColumn.UpdatePositions -> TBaseVirtualTree.UpdateHorizontalScrollBar -> Boom.

I've inserted a line

  if csDestroying in FHeader.Treeview.ComponentState then Exit;

into TVirtualTreeColumns.UpdatePositions to fix this problem.

Achim

[Joachim Marder]

Thanks Achim, I just committed this change to the trunk.

--