Fwd: Mozilla Add-ons: Vimperator 3.16.0 Approved
21 views
Skip to first unread message
Martin Stubenschrott
Feb 18, 2017, 7:03:19 PM2/18/17
to Vimperator Mailing List
fyi.
Great it got approved, but still some issues.
---------- Forwarded message ----------
From: <amo-e...@mozilla.org>
Date: Fri, Feb 17, 2017 at 11:35 PM
Subject: Mozilla Add-ons: Vimperator 3.16.0 Approved
To: stuben...@vimperator.org
Hello,
Your add-on, Vimperator 3.16.0, has been approved and is now available for download in our gallery at https://addons.mozilla.org/addon/vimperator/
Reviewer:
Jorge Villalobos
Comments:
Thank you for your contribution.
Please look into these for your next update:
1) Calling `nsITransferable.init()` with a null first argument has the potential to leak data across private browsing mode sessions. `null` is appropriate only when reading data or writing data which is not associated with a particular window. File common/content/util.js#L667
2) Under Windows 10 64 bits / Nightly 54, button "Options" in about:addons for your add-on shows a blank small window that close right away.
If you want to respond to this review, or have any questions about it, please reply to this email or join #addon-reviewers on irc.mozilla.org.
To learn more about the review process, please visit https://developer.mozilla.org/en-US/Add-ons/AMO/Policy/Reviews
--
Mozilla Add-ons Team
https://addons.mozilla.org
===================================================================
You received this email because you're subscribed to:
* email me when my add-on is reviewed by a reviewer
You can't unsubscribe from this type of email.
Manage email notifications: https://addons.mozilla.org/users/edit#acct-notify
From: <amo-e...@mozilla.org>
Date: Fri, Feb 17, 2017 at 11:35 PM
Subject: Mozilla Add-ons: Vimperator 3.16.0 Approved
To: stuben...@vimperator.org
Hello,
Your add-on, Vimperator 3.16.0, has been approved and is now available for download in our gallery at https://addons.mozilla.org/addon/vimperator/
Reviewer:
Jorge Villalobos
Comments:
Thank you for your contribution.
Please look into these for your next update:
1) Calling `nsITransferable.init()` with a null first argument has the potential to leak data across private browsing mode sessions. `null` is appropriate only when reading data or writing data which is not associated with a particular window. File common/content/util.js#L667
2) Under Windows 10 64 bits / Nightly 54, button "Options" in about:addons for your add-on shows a blank small window that close right away.
If you want to respond to this review, or have any questions about it, please reply to this email or join #addon-reviewers on irc.mozilla.org.
To learn more about the review process, please visit https://developer.mozilla.org/en-US/Add-ons/AMO/Policy/Reviews
--
Mozilla Add-ons Team
https://addons.mozilla.org
===================================================================
You received this email because you're subscribed to:
* email me when my add-on is reviewed by a reviewer
You can't unsubscribe from this type of email.
Manage email notifications: https://addons.mozilla.org/users/edit#acct-notify
Gary Katsevman
Feb 18, 2017, 7:22:36 PM2/18/17
to vimpera...@googlegroups.com
#2 is already being worked on: https://github.com/vimperator/vimperator-labs/pull/702
And I opened an issue for #1: https://github.com/vimperator/vimperator-labs/issues/719
--
---
You received this message because you are subscribed to the Google Groups "vimperator labs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vimperator-labs+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Reply all
Reply to author
Forward
0 new messages