[vim/vim] fix(gtk): use GTK_DIALOG_MODAL over type hints (PR #20727)
dezza
Closes: #17760
It is unclear whether #172 was properly fixed by
#16100
Remaining issues on wayland:
-
Centering dialog
(unlikely to exist a proper fix as compositor is supposed to center the dialog, not gtk3 - so it will become an advanced hack) -
Find/replace dialog starts maximized , occupying entire
gui.mainwin -
Other dialogs needs tested
@CS-cwhite can you clarify if the issue was fixed for you with your PR or it reappeared? Either way 5049daf
GDK_WINDOW_TYPE_HINT_POPUP_MENU is the wrong fix, since it causes new issues (unfocus on wayland, #17760)
@aswild welcome to test this PR
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20727
Commit Summary
- 81c7c2c fix(gtk): use GTK_DIALOG_MODAL over type hints
File Changes
(1 file)
- M src/gui_gtk.c (5)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Allen Wild
aswild left a comment (vim/vim#20727)Hi @dezza, thanks for the patch! It's working alright for me on my WSL setup. Seems like the same behavior as setting GDK_WINDOW_TYPE_HINT_DIALOG.
There's one quirk/bug, in that it's possible to click the main window and send the dialog to the background. When the dialog is "hidden", moving the mouse around or clicking outside the window usually gets it back. This seems to happen on wayland or x11 mode.
Arch Linux, gtk3 3.24.52, WSL2.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.