[vim/vim] CI: Check COVERITY_SCAN_TOKEN in coverity scan (PR #11609)

9 views
Skip to first unread message

K.Takata

unread,
Nov 24, 2022, 7:40:29 AM11/24/22
to vim/vim, Subscribed

This fixes the issue that has been fixed by 9.0.0937 in the different way (as I wrote in #11604 (comment)).
The patch 9.0.0937 may ignore actual errors also. I don't think it is a good way.


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/11609

Commit Summary

  • 58351fa CI: Check $TOKEN in coverity scan

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/11609@github.com>

Shane-XB-Qian

unread,
Nov 24, 2022, 7:50:44 AM11/24/22
to vim/vim, Subscribed

The patch 9.0.0937 may ignore actual errors also.

it is useless 'actual' error if it is in 'fork' repo, but it should be would not ignore error in main repo.

// but anyway, as the comment #11604 (comment) said the really good way should be finding out if: ${{ !github.event.foo.bar.fork }} that var and ignore the cov process globally if that's a fork repo.
// but just so far i donot know what's that var, later maybe can refine that pr to that way or someone very knew ci var can tell what's the var is then early return the cov process if it is a forked repo.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/11609/c1326409762@github.com>

codecov[bot]

unread,
Nov 24, 2022, 7:56:31 AM11/24/22
to vim/vim, Subscribed

Codecov Report

Merging #11609 (58351fa) into master (e2da598) will decrease coverage by 1.63%.
The diff coverage is n/a.

@@            Coverage Diff             @@

##           master   #11609      +/-   ##

==========================================

- Coverage   78.08%   76.44%   -1.64%     

==========================================

  Files         148      148              

  Lines      147885   147699     -186     

  Branches    38310    38240      -70     

==========================================

- Hits       115481   112915    -2566     

- Misses      20417    23042    +2625     

+ Partials    11987    11742     -245     
Flag Coverage Δ
mingw-x64-HUGE 76.44% <ø> (+<0.01%) ⬆️
mingw-x86-HUGE ?
windows 76.44% <ø> (-1.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/vimrun.c 0.00% <0.00%> (-50.00%) ⬇️
src/gui_dwrite.cpp 1.19% <0.00%> (-44.74%) ⬇️
src/xpm_w32.c 0.00% <0.00%> (-38.47%) ⬇️
src/ui.c 35.31% <0.00%> (-32.01%) ⬇️
src/gui.c 36.08% <0.00%> (-29.45%) ⬇️
src/testing.c 77.02% <0.00%> (-16.77%) ⬇️
src/clipboard.c 44.21% <0.00%> (-15.94%) ⬇️
src/gui_w32.c 24.07% <0.00%> (-13.12%) ⬇️
src/mouse.c 38.72% <0.00%> (-12.27%) ⬇️
src/beval.c 0.00% <0.00%> (-12.00%) ⬇️
... and 70 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/11609/c1326415811@github.com>

Bram Moolenaar

unread,
Nov 24, 2022, 3:25:37 PM11/24/22
to vim/vim, Subscribed

The sound-dummy problem has been fixed, please sync to head to trigger the tests.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/11609/c1326817559@github.com>

Bram Moolenaar

unread,
Nov 24, 2022, 7:57:51 PM11/24/22
to vim/vim, Subscribed

Closed #11609 via ad85af5.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/11609/issue_event/7889288367@github.com>

Reply all
Reply to author
Forward
0 new messages