[vim/vim] runtime(vim): set 'path' to common Vim directories (PR #19219)
Mateo Gjika
ping @dkearns
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19219
Commit Summary
- 55a1bde runtime(vim): set 'path' to common Vim directories
File Changes
(1 file)
- M runtime/ftplugin/vim.vim (6)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
dkearns
dkearns left a comment (vim/vim#19219)I don't understand the proposed value, wouldn't we want to use 'rtp'?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Mateo Gjika
mateoxh left a comment (vim/vim#19219)I find it useful when working on plugins or Vim's runtime files, for example it makes searching for files buried inside autoload/ easier.
I think 'rtp' adds too much noise and it's really not important for plugin development. Anyway, it's still better than the default value.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19219)Thanks. I agree rtp might be a bit too much and may therefore slow down finding files. Thanks
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
nyngwang
nyngwang left a comment (vim/vim#19219)This "optimization" breaks my old expected behaviour.
I've already set path=. in my vimrc.
Before this update, a plain :find can show me all files only under the same level as the current buffer/file.
If I really need to locate files under, say <tab-root>/autoload, I can simply do :find ./autoload to shrink the search scope myself.
So the old behaviour is good enough if people read the manual carefully and learn how to use :tcd(to change the meaning of :find ./) and set path=.(to change the search path of :find when without a leading ./).
Now, this PR seems to force everyone to set a local-option for path, which is a global-local option. If you really need to set the same local-option for every window for a global-local option, you're probably doing it wrong.
Why forcing everyone to use such a default? If you really need it, can't you just put it in your own config?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
nyngwang
nyngwang left a comment (vim/vim#19219)I don't see the point of this "optimization". The fact that path is a global-local option means that people may depend on using only the global value, and set a local one for some windows only when necessary. In this superfluous PR (wait, what concrete problem you were trying to solve?), you're forcing a local option to be set for every vim-file window and therefore shadowing the global one.
In my case, I've already set path=. in my vimrc. Before this PR, a plain :find can show me all files only under ., which is clearly documented to mean "the same level as the current buffer/file".
If I really need to locate files under, say <cwd>/autoload/, I can simply do :find ./autoload, where . here means something different "<cwd>", to shrink the search scope myself.
Now, how do I undo the mess this PR has done? I have to run a tabdo windo setl path= only because you think
I think 'rtp' adds too much noise and it's really not important for plugin development. Anyway, it's still better than the default value.
Why forcing everyone to adopt such a default? If you really need it, can't you just put it in your own config by some autocmd?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.