[vim/vim] Two engines pattern (PR #10439)
Christian Brabandt
Currently, the pattern %#= is allowed everywhere, but only if it is at the start of the pattern, it will actually select the correct regexp engine.
However, Vim will happily accept a pattern like 'foo%#=2bar' but will interpret \%# as the current cursor position. So make the regexp a bit more strict and output an error, if the special atom \%#= is found anywhere but at the start of the pattern.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/10439
Commit Summary
File Changes
(5 files)
- M runtime/doc/pattern.txt (2)
- M src/errors.h (2)
- M src/regexp_bt.c (14)
- M src/regexp_nfa.c (14)
- M src/testdir/test_regexp_latin.vim (17)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra pushed 1 commit.
- 6865cbc only allow \%#= at the start of the pattern
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
codecov[bot]
Codecov Report
Merging #10439 (6865cbc) into master (b1040dc) will increase coverage by
0.00%.
The diff coverage is64.28%.
@@ Coverage Diff @@ ## master #10439 +/- ## ======================================= Coverage 81.63% 81.63% ======================================= Files 158 158 Lines 184714 184729 +15 Branches 41765 41767 +2 ======================================= + Hits 150789 150803 +14 + Misses 21436 21431 -5 - Partials 12489 12495 +6
| Flag | Coverage Δ | |
|---|---|---|
| huge-clang-none | 82.55% <57.14%> (-0.01%) |
⬇️ |
| linux | 82.55% <57.14%> (-0.01%) |
⬇️ |
| mingw-x64-HUGE | 0.00% <0.00%> (ø) |
|
| mingw-x64-HUGE-gui | 78.04% <62.50%> (+0.01%) |
⬆️ |
| windows | 76.82% <50.00%> (+0.01%) |
⬆️ |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/regexp_bt.c | 87.40% <28.57%> (-0.18%) |
⬇️ |
| src/regexp_nfa.c | 89.77% <100.00%> (+0.01%) |
⬆️ |
| src/sound.c | 64.36% <0.00%> (-1.73%) |
⬇️ |
| src/libvterm/src/state.c | 38.39% <0.00%> (-0.07%) |
⬇️ |
| src/channel.c | 83.92% <0.00%> (-0.05%) |
⬇️ |
| src/version.c | 84.16% <0.00%> (ø) |
|
| src/os_win32.c | 57.05% <0.00%> (+0.07%) |
⬆️ |
| src/misc2.c | 88.89% <0.00%> (+0.09%) |
⬆️ |
| src/ex_cmds.c | 85.28% <0.00%> (+0.10%) |
⬆️ |
| ... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update b1040dc...6865cbc. Read the comment docs.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Bram Moolenaar
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.