Commit: patch 9.2.0086: Coverity complains that ScreenLines can be NULL

0 views
Skip to first unread message

Christian Brabandt

unread,
Mar 1, 2026, 12:31:52 PM (3 days ago) Mar 1
to vim...@googlegroups.com
patch 9.2.0086: Coverity complains that ScreenLines can be NULL

Commit: https://github.com/vim/vim/commit/08e758bb7045257f1486b7b551b7385ad271c2f4
Author: Christian Brabandt <c...@256bit.org>
Date: Sun Mar 1 17:21:16 2026 +0000

patch 9.2.0086: Coverity complains that ScreenLines can be NULL

Problem: Coverity complains that ScreenLines can be NULL
(after v9.2.0080)
Solution: Remove null test

closes: #19538
CID: 1682067

Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/popupwin.c b/src/popupwin.c
index e49a86348..1d8356ccf 100644
--- a/src/popupwin.c
+++ b/src/popupwin.c
@@ -4414,7 +4414,7 @@ draw_opacity_padding_cell(

// Prefer current screen state for detecting a wide char, since the
// saved data may not contain a reliable right-half marker.
- if (base_off >= 0 && ScreenLines != NULL)
+ if (base_off >= 0)
{
if (ScreenLinesUC != NULL
&& ScreenLinesUC[base_off] != 0
diff --git a/src/version.c b/src/version.c
index d001aa53f..e4cec8400 100644
--- a/src/version.c
+++ b/src/version.c
@@ -734,6 +734,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 86,
/**/
85,
/**/
Reply all
Reply to author
Forward
0 new messages