[vim/vim] runtime(mysql): update syntax script (PR #15311)

Yinzuo Jiang

unread,

Jul 20, 2024, 4:03:14 AM (2 days ago) Jul 20

to vim/vim, Subscribed

Problem:

syn region ...s in syntax/mysql.vim match function names inaccurately.
no syntax rules for mysql window function.
coarse highlight definition in syntax/mysql.vim.

Solution:

add \<...\> to match the function name accurately.
add syntax rules for mysql window function.
enhance the highlight definition.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/15311

Commit Summary

01c8bb4 runtime(mysql): update syntax script

File Changes

(1 file)

M runtime/syntax/mysql.vim (309)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Yinzuo Jiang

unread,

Jul 20, 2024, 4:03:46 AM (2 days ago) Jul 20

to vim/vim, Subscribed

@pronovic could you please review the PR?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Jul 20, 2024, 5:54:15 AM (2 days ago) Jul 20

to vim/vim, Subscribed

thanks, but I think adding \> between the function end name and the closing parenthesis does't really make a difference.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Yinzuo Jiang

unread,

Jul 20, 2024, 10:17:54 AM (2 days ago) Jul 20

to vim/vim, Push

@jiangyinzuo pushed 1 commit.

8de0eca runtime(mysql): update syntax script

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

Yinzuo Jiang

unread,

Jul 20, 2024, 10:22:39 AM (2 days ago) Jul 20

to vim/vim, Push

@jiangyinzuo pushed 1 commit.

316cf88 runtime(mysql): update syntax script

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Yinzuo Jiang

unread,

Jul 20, 2024, 10:58:02 AM (2 days ago) Jul 20

to vim/vim, Subscribed

thanks, but I think adding \> between the function end name and the closing parenthesis does't really make a difference.

I have removed all the '>'s in this PR.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Jul 21, 2024, 3:23:43 AM (yesterday) Jul 21

to vim/vim, Subscribed

thanks!

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Jul 21, 2024, 3:28:55 AM (yesterday) Jul 21

to vim/vim, Subscribed

Closed #15311 via 6e37575.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward