[vim/vim] No warning when IPC registers are not available (PR #16013)

15 views
Skip to first unread message

Christian Brabandt

unread,
Nov 7, 2024, 4:50:18 PM11/7/24
to vim/vim, Subscribed

Vim silently uses the 0 register, when clipboard/register * or + is not available. This might be a bit unexpected for the user.

So let's just warn when we silently (re-)use register 0.

related: #14768

Draft, because it is missing test.


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/16013

Commit Summary

  • 4145981 No warning when IPC registers are not available

File Changes

(7 files)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16013@github.com>

Christian Brabandt

unread,
Nov 10, 2024, 9:24:06 AM11/10/24
to vim/vim, Push

@chrisbra pushed 1 commit.


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16013/before/41459813c7dff47987ccf6e6f22d33638397db5a/after/65b4d679845c29e6629b9b8e0c41ababed62769d@github.com>

Christian Brabandt

unread,
Nov 10, 2024, 1:41:22 PM11/10/24
to vim/vim, Push

@chrisbra pushed 4 commits.

  • 28034fa cb: Enable Debugging builds, disable debugging mode for libvterm
  • 0e5e809 No warning when IPC registers are not available
  • 8edc932 Add a test
  • 0307f4b fix failures

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16013/before/65b4d679845c29e6629b9b8e0c41ababed62769d/after/0307f4bc260753923c6a8c786215c34c7e00f0cf@github.com>

Christian Brabandt

unread,
Nov 10, 2024, 2:42:06 PM11/10/24
to vim/vim, Push

@chrisbra pushed 1 commit.

  • f70680c No warning when IPC registers are not available

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16013/before/0307f4bc260753923c6a8c786215c34c7e00f0cf/after/f70680c3ddb7377d6392de84a10383998163c44c@github.com>

Christian Brabandt

unread,
Nov 11, 2024, 2:58:06 PM11/11/24
to vim/vim, Subscribed

Closed #16013 via 45e0704.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16013/issue_event/15254885581@github.com>

zeertzjq

unread,
Nov 14, 2024, 9:34:03 PM11/14/24
to vim/vim, Subscribed

@zeertzjq commented on this pull request.


In src/message.c:

> @@ -55,6 +55,9 @@ static int msg_hist_len = 0;
 static FILE *verbose_fd = NULL;
 static int  verbose_did_open = FALSE;
 
+static int  did_warn_clipboard = FALSE;
+static char *warn_clipboard = "W23: Clipboard register not available, using register 0";

Is an N_() needed here so that this message is translatable?


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16013/review/2437546736@github.com>

Christian Brabandt

unread,
Nov 16, 2024, 8:34:03 AM11/16/24
to vim/vim, Subscribed

@chrisbra commented on this pull request.


In src/message.c:

> @@ -55,6 +55,9 @@ static int msg_hist_len = 0;
 static FILE *verbose_fd = NULL;
 static int  verbose_did_open = FALSE;
 
+static int  did_warn_clipboard = FALSE;
+static char *warn_clipboard = "W23: Clipboard register not available, using register 0";

Hm, N_() or _(). ?


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/16013/review/2440369028@github.com>

Reply all
Reply to author
Forward
0 new messages