[vim/vim] Update GDB syntax file (WIP) (PR #10649)
Doug Kearns
This addresses some queries in #8276.
It also seems this file hasn't been updated in some time so I'll look at
bringing it up to date with version 12.
@GitMensch if you have any suggestions beyond a general update let me know.
- Add Guile and Python command highlighting
- Update list of info subcommands
- Update list of set subcommands
- Simplify statement achoring
- Add server prefix highlighting
- Whitespace fix
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/10649
Commit Summary
- 6909a99 Add Guile and Python command highlighting
- 18333ea Update list of info subcommands
- ce63f87 Update list of set subcommands
- 1092a1b Simplify statement achoring
- 05c4380 Add server prefix highlighting
- 326d7b0 Whitespace fix
File Changes
(1 file)
- M runtime/syntax/gdb.vim (172)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
codecov[bot]
Codecov Report
Merging #10649 (326d7b0) into master (95afae6) will increase coverage by
0.90%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #10649 +/- ## ========================================== + Coverage 81.70% 82.61% +0.90% ========================================== Files 158 148 -10 Lines 185485 172831 -12654 Branches 41952 39074 -2878 ========================================== - Hits 151554 142779 -8775 + Misses 21471 17457 -4014 - Partials 12460 12595 +135
| Flag | Coverage Δ | |
|---|---|---|
| huge-clang-none | 82.61% <ø> (-0.01%) |
⬇️ |
| linux | 82.61% <ø> (-0.01%) |
⬇️ |
| mingw-x64-HUGE | ? |
|
| mingw-x64-HUGE-gui | ? |
|
| windows | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/highlight.c | 78.41% <0.00%> (-2.69%) |
⬇️ |
| src/time.c | 87.08% <0.00%> (-2.56%) |
⬇️ |
| src/misc2.c | 86.68% <0.00%> (-2.52%) |
⬇️ |
| src/help.c | 80.07% <0.00%> (-2.38%) |
⬇️ |
| src/buffer.c | 84.11% <0.00%> (-2.35%) |
⬇️ |
| src/gui.c | 71.04% <0.00%> (-2.07%) |
⬇️ |
| src/session.c | 63.15% <0.00%> (-1.94%) |
⬇️ |
| src/menu.c | 81.36% <0.00%> (-1.83%) |
⬇️ |
| src/arglist.c | 83.83% <0.00%> (-1.72%) |
⬇️ |
| src/vim9cmds.c | 85.16% <0.00%> (-1.70%) |
⬇️ |
| ... and 128 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 95afae6...326d7b0. Read the comment docs.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Simon Sobisch
Not much comments from me other than: totally cool, and a bit sad that it comes after the Vim release.
Embedded python also seems to work fine!
It likely would be useful to highlight sub-settings, for example:
# personal history file set history save on set history filename ~/.gdb_history set history remove-duplicates 1 # setup for vim's termdebug set print elements 250 set print repeats 20 set pagination off set breakpoint pending on # general setup set print frame-arguments all
where only the "set" and "history"/"print" are highlighted.
At least with "set" it also seems reasonable to highlight the common values "on", "off", "unlimited".
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Doug Kearns
@dkearns pushed 6 commits.
- 0777080 Add Guile and Python command highlighting
- edc48ff Update list of info subcommands
- 110a54a Update list of set subcommands
- cb1a3bc Simplify statement anchoring
- 330ff31 Add server prefix highlighting
- 04cfc70 Whitespace fix
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Doug Kearns
@dkearns pushed 2 commits.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
Any updates on this?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
dkearns
It seems the syntax file in my personal runtime directory is about a thousand lines longer than the one in this PR. I'm not sure if this is a positive discovery but I'll try and sort it out in the next week or so.
Thanks for the gentle reminder.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
dkearns
@GitMensch maybe you can give the latest syntax file a quick run some time and let me know if there's anything obvious that needs improvement.
There's still a lot that could be done but it's probably a good idea push an update soon...this year.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
dkearns
@fleiner, I was under the impression that you were no longer maintaining this file as the latest on your website (mentioned in the hearder) is from 2003 but I see it has been added to a GitHub more recently.
If you're not interested in this rather large patch I'm happy to maintain it externally or alternatively take over maintenance of the distributed file. Let me know, thanks.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
dkearns
@dkearns pushed 16 commits.
- 40153e0 Add Guile and Python command highlighting
- d217705 Update list of info subcommands
- 258013a Update list of set subcommands
- 7a377aa Simplify statement anchoring
- 92e5944 Add server prefix highlighting
- e3b4ec2 Whitespace fix
- 513d5e5 Highlight line continuations
- d22baec Update command list to version 12
- aa532ed Improve alias command highlighting
- bf196d5 Highlight subcommands of set
- 820be6c Add matchit, browsefilter and comment formatting support
- 40c6fa4 Support embedded C in compiler {code|print} commands
- 7ab4ab6 Fix "All Files" browsefilter pattern
- d1b582d Set Matchit to case-sensitive
- 960ae43 Add largely complete settings highlighting and folding
- 8f8606b Add syntax documentation
You are receiving this because you are subscribed to this thread.
dkearns
@dkearns pushed 5 commits.
- 332e575 Add matchit, browsefilter and comment formatting support
- 4951f6b Support embedded C in compiler {code|print} commands
- 6aab437 Set Matchit to case-sensitive
- 2a7ba28 Add largely complete settings highlighting and folding
- 01bc18a Add syntax documentation
You are receiving this because you are subscribed to this thread.
PEMessage
PEMessage left a comment (vim/vim#10649)Any update?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
dkearns
dkearns left a comment (vim/vim#10649)Yes, GDB is now at version 16. :)
I'll take over as maintainer as we haven't heard from Claudio in a long time. Thanks for all your efforts Claudio!
I'll try and figure out where I was up to and push something out in the next couple of weeks. If I do not, please feel free to yell at me.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Simon Sobisch
GitMensch left a comment (vim/vim#10649)When you consider the highlighting to be good - I'd suggest to check out https://github.com/pirpyn/gdb-syntax-vscode/tree/master/tests and open each of those files in vim, checking its results.
For editing: working outline (in case of defined functions) and goto (maybe also for vars $set) would be nice.
Hm, and the first time I'm thinking about this more: an online-help (maybe as "popup") that leverages gdb, seems quite useful.
For example to get more information about "br" in a script we could get the output of gdb --batch -ex "help br" and present it to the user.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
dkearns
@dkearns pushed 17 commits.
- 878cb06 Add Guile and Python command highlighting
- b5f1892 Update list of info subcommands
- c2c2983 Update list of set subcommands
- 8cb7236 Simplify statement anchoring
- c207011 Add server prefix highlighting
- c992388 Whitespace fix
- fc66c5c Highlight line continuations
- 598c30f Update command list to version 12
- 475d1c0 Improve alias command highlighting
- 25e9f1f Highlight subcommands of set
- abc01d4 Add matchit, browsefilter and comment formatting support
- c77aff8 Support embedded C in compiler {code|print} commands
- 51cf8a4 Set Matchit to case-sensitive
- 5aaa54c Add largely complete settings highlighting and folding
- dd2777e Add syntax documentation
- bc619f6 New maintainer Doug Kearns, thanks Claudio.
- 55be197 Update doc/tags for new syntax help
You are receiving this because you are subscribed to this thread.
Simon Sobisch
GitMensch left a comment (vim/vim#10649)@dkearns Can you please rebase so that we may include whichever parts are non-conflicting?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
dkearns
@dkearns pushed 19 commits.
- 7cd60bf Add Guile and Python command highlighting
- b305f6b Update list of info subcommands
- b5a71c6 Update list of set subcommands
- 4db0177 Simplify statement anchoring
- 32e9293 Add server prefix highlighting
- 4225e20 Whitespace fix
- 5580a10 Highlight line continuations
- 39329db Update command list to version 12
- 3530014 Improve alias command highlighting
- f062b64 Highlight subcommands of set
- 4c64e1f Add matchit, browsefilter and comment formatting support
- 4e36294 Support embedded C in compiler {code|print} commands
- 3003e89 Set Matchit to case-sensitive
- d4fbf0e Add largely complete settings highlighting and folding
- 2bde56f Add syntax documentation
- 6dd96ce Update doc/tags for new syntax help
- 3d2eb9c Add help all smoke test
- 79f4372 Whitespace fixes.
- ed8ba2c more fixes - check these
You are receiving this because you are subscribed to this thread.
