[vim/vim] Netrw Tree Style Listing moves the cursor to a different position. (PR #10001)
James Cherti
This pull request fixes a bug in Netrw. Netrw Tree Style Listing moves the cursor to a different position when the user presses the Enter key to perform a directory listing; in a Netrw buffer that the user has reloaded with ':edit' or ':buffer'.
The "Perform Directory Listing" part of the function 's:NetrwBrowse()' should only call 'winrestview()' when the listing style of Netrw is not Tree Style Listing.
Steps to reproduce the bug
- Create the directory hierarchy:
$ mkdir -p ~/vim_bug/{dir1,dir2,dir3}
$ touch ~/vim_bug/{dir1,dir2,dir3}/{file1,file2,file3}
$ cd ~/vim_bug
- Execute Vim:
$ vim -u NONE -c 'set nocompatible' -c 'let g:netrw_liststyle = 3' -c "source /usr/share/vim/vim82/plugin/netrwPlugin.vim"
- Edit the current directory with Netrw:
:edit . - Move the cursor to "dir1" and press the Enter key.
- Move the cursor to "file1" and press the Enter key.
- Reopen netrw:
:edit . - Move the cursor to "dir3" and press the Enter key.
Netrw will move the cursor to a different position ("file1" under "dir1").
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/10001
Commit Summary
- bf4a1da Fix: Netrw Tree Style Listing moves the cursor to a different position.
File Changes
(1 file)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
codecov[bot]
Codecov Report
Merging #10001 (bf4a1da) into master (5c68617) will decrease coverage by
73.92%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #10001 +/- ## =========================================== - Coverage 75.93% 2.01% -73.93% =========================================== Files 151 152 +1 Lines 146483 170210 +23727 Branches 38160 39362 +1202 =========================================== - Hits 111235 3428 -107807 - Misses 23518 166089 +142571 + Partials 11730 693 -11037
| Flag | Coverage Δ | |
|---|---|---|
| huge-gcc-unittests | 2.01% <ø> (?) |
|
| linux | 2.01% <ø> (?) |
|
| mingw-x64-HUGE | ? |
|
| mingw-x64-HUGE-gui | ? |
|
| windows | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/sha256.c | 0.00% <0.00%> (-96.80%) |
⬇️ |
| src/crypt_zip.c | 0.00% <0.00%> (-96.67%) |
⬇️ |
| src/evalbuffer.c | 0.00% <0.00%> (-92.46%) |
⬇️ |
| src/vim9compile.c | 0.00% <0.00%> (-91.96%) |
⬇️ |
| src/eval.c | 0.10% <0.00%> (-91.33%) |
⬇️ |
| src/typval.c | 2.56% <0.00%> (-90.95%) |
⬇️ |
| src/float.c | 0.00% <0.00%> (-90.62%) |
⬇️ |
| src/vim9expr.c | 0.00% <0.00%> (-90.45%) |
⬇️ |
| src/usercmd.c | 0.00% <0.00%> (-89.69%) |
⬇️ |
| src/blob.c | 0.00% <0.00%> (-89.53%) |
⬇️ |
| ... and 154 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 5c68617...bf4a1da. Read the comment docs.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
K.Takata
Cc @cecamp
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
James Cherti
@jamescherti pushed 1 commit.
- eca3524 Fix: Netrw Tree Style Listing moves the cursor to a different position.
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
James Cherti
I couldn't reproduce the issue anymore. I am going to close this pull request.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
James Cherti
Closed #10001.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
James Cherti
Reopened #10001.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
James Cherti
I can still reproduce the issue. I am going to reopen the pull request.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.