[vim/vim] Get rid off some legacy vim syntax, added deprecation warnings and test. (PR #15304)
ubaldot
Q1: Are legacy v:true/v:false equivalent to Vim9 true/false?
Q2: Would that be possible to rewrite the termdebug tests in Vim9?
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/15304
Commit Summary
- 6f1144b Get rid off some legacy vim syntax, added deprecation warnings and
File Changes
(3 files)
- M runtime/doc/terminal.txt (16)
- M runtime/pack/dist/opt/termdebug/plugin/termdebug.vim (155)
- M src/testdir/test_termdebug.vim (51)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra commented on this pull request.
> @@ -1530,9 +1530,9 @@ in a buffer with 'buftype' set to "prompt". This works slightly differently: *termdebug_use_prompt* Prompt mode can be used even when the |+terminal| feature is present with: > - let g:termdebug_config['use_prompt'] = 1 + let g:termdebug_config['use_prompt'] = true
This uses legacy vim script syntax, so should be v:true
> If there is no g:termdebug_config you can use: > - let g:termdebug_use_prompt = 1 + let g:termdebug_use_prompt = true
same here
> @@ -1544,26 +1544,26 @@ are reset to their original values once the termdebug session concludes. *termdebug_map_K* *termdebug-mappings* The K key is normally mapped to |:Evaluate| unless a buffer local (|:map-local|) mapping to K already exists. If you do not want this use: > - let g:termdebug_config['map_K'] = 0 + let g:termdebug_config['map_K'] = false
and here
In runtime/pack/dist/opt/termdebug/plugin/termdebug.vim:
> @@ -63,7 +63,7 @@ command -nargs=+ -complete=file -bang TermdebugCommand StartDebugCommand(<bang>0 enum Way Prompt, - Terminal + Terminal
white space error
In runtime/pack/dist/opt/termdebug/plugin/termdebug.vim:
> })
if job_status(gdbjob) != "run"
Echoerr('Failed to start gdb')
exe $'bwipe! {promptbufnr}'
return
endif
exe $'au BufUnload <buffer={promptbufnr}> ++once ' ..
- 'call job_stop(gdbjob, ''kill'')'
+ 'job_stop(gdbjob, ''kill'')'
I am not sure this is correct. Are you sure the exec'ed string is evaluated in vim9 script semantics?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
Thanks. In general, it would be beneficial to have separate commits for
- cleaning up white space
- adding new functions (e.g. for the deprecation warning)
- changing arguments to true/false
That makes reviewing a bit easier.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
ubaldot
You are right, sorry!
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
ubaldot
@ubaldot pushed 1 commit.
- 9541da0 true -> v:true in docs, fixed whitespace error.
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
ubaldot
@ubaldot commented on this pull request.
In runtime/pack/dist/opt/termdebug/plugin/termdebug.vim:
> })
if job_status(gdbjob) != "run"
Echoerr('Failed to start gdb')
exe $'bwipe! {promptbufnr}'
return
endif
exe $'au BufUnload <buffer={promptbufnr}> ++once ' ..
- 'call job_stop(gdbjob, ''kill'')'
+ 'job_stop(gdbjob, ''kill'')'
Not really... I replaced it back.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
thanks!
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.