Re: Retaining marks column on folded line
Christian Brabandt
> On Jan 10, 10:25�am, AK <andrei....@gmail.com> wrote:
>> I suspect this isn't possible in current vim but I'm wondering if it's
possible to add this to the next version.. Currently, if you have a
marks column and a folded line, marks column is blocked and overwritten
with a blank background of folded column.
>> When you have many folded functions or classes, that looks really ugly.
I think majority of people would prefer either to have contents of mark
of 1st folded line there or at least blank space of the same colour of
marks column.
>
> What is the "marks column"? Is it some plugin you have installed? And
can you post a screenshot? I really am having trouble picturing what you
are describing.
I think, if you have defined a sign in a line and this line is folded away
the sign won't be shown. I can reproduce it here.
I would consider this a bug, therefore forwarding to vim-dev.
regards,
Christian
Bram Moolenaar
Christian Brabandt wrote:
Thanks for the patch.
Is there a simple way to see the effect, e.g., using src/fold.c?
--
Contrary to popular belief, Unix is user friendly.
It just happens to be selective about who it makes friends with.
-- Dave Parnas
/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
Christian Brabandt
On Sa, 15 Jan 2011, Bram Moolenaar wrote:
> Thanks for the patch.
>
> Is there a simple way to see the effect, e.g., using src/fold.c?
Open fold.c with your vim.
:sign define marks text='a texthl=Search
:sign place 1 line=20 name=marks buffer=1
In a non-patched vim, the sign-column, won't be shown and be overdrawn
by the folds. Additionally, a sign, that is on the first line of the
fold, won't be shown as well.
regards,
Christian
Bram Moolenaar
Christian Brabandt wrote:
I finally had time to look into this. Sorry for the delay.
I think the current behavior is correct. Showing a sign only when it
happens to be on the first line of a closed fold doesn't seem right.
Why not show a sign on the second line or last line of the fold?
Since we don't show signs for the folded region, I think it's good to
also use the closed-fold color in the sign column.
--
If Microsoft would build a car...
... Occasionally, executing a maneuver such as a left turn
would cause your car to shut down and refuse to restart, in
which case you would have to reinstall the engine.
Christian Brabandt
On Mo, 13 Jun 2011, Bram Moolenaar wrote:
> I finally had time to look into this. Sorry for the delay.
>
> I think the current behavior is correct. Showing a sign only when it
> happens to be on the first line of a closed fold doesn't seem right.
> Why not show a sign on the second line or last line of the fold?
Basically for the same reason, you show the line number of the first
line in the fold. But I don't have a strong feeling for it anyway. The
current behaviour is fine for me.
I just took the chance, when this question came up, to look into it and
give something back to the community.
> Since we don't show signs for the folded region, I think it's good to
> also use the closed-fold color in the sign column.
I don't really mind. In my opinion, it looks a little bit odd, though.
regards,
Christian
--