[vim/vim] heap buffer overflow with long generic function name (PR #19727)
Christian Brabandt
Problem: Using a long generic function name may cause a heap buffer
overflow in common_function().
Solution: Allocate memory for the full name instead of using IObuff.
(Kaixuan Li)
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19727
Commit Summary
- bf7fd77 heap buffer overflow with long generic function name
File Changes
(2 files)
- M src/evalfunc.c (10)
- M src/testdir/test_vimscript.vim (13)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
@yegappan commented on this pull request.
In src/testdir/test_vimscript.vim:
> @@ -7689,6 +7689,19 @@ func Test_catch_pattern_trailing_chars()
bw!
endfunc
+" Test for long gerneric type name {{{1
+func Test_function_long_generic_name()
+ func TestFunc()
Should this be def TestFunc()?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
@yegappan commented on this pull request.
In src/testdir/test_vimscript.vim:
> @@ -7689,6 +7689,19 @@ func Test_catch_pattern_trailing_chars()
bw!
endfunc
+" Test for long gerneric type name {{{1
+func Test_function_long_generic_name()
Both of these functions should be def functions?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra commented on this pull request.
In src/testdir/test_vimscript.vim:
> @@ -7689,6 +7689,19 @@ func Test_catch_pattern_trailing_chars()
bw!
endfunc
+" Test for long gerneric type name {{{1
+func Test_function_long_generic_name()
shouldn't really matter, no?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
@yegappan commented on this pull request.
In src/testdir/test_vimscript.vim:
> @@ -7689,6 +7689,19 @@ func Test_catch_pattern_trailing_chars()
bw!
endfunc
+" Test for long gerneric type name {{{1
+func Test_function_long_generic_name()
To detect this buffer overflow condition, func or def definition shouldn't really matter.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
@yegappan approved this pull request.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.