[vim/vim] runtime/syntax/make: highlights in define..undef block (PR #18403)
littlewu2508
Previously contents in makeDefine are nearly highlighted as Define, so comments and targets shares the same color as Define, making it hard to distinguish if someone write large block of targets-recipes as defined function.
Such scenario is common in building data analysis pipeline. Recipes are reused and targets may have multiple variables, and a single % implicit rule is not enough.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/18403
Commit Summary
File Changes
(1 file)
- M runtime/syntax/make.vim (30)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#18403)Thanks, let's try to ping @rohieb
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Roland Hieber
@rohieb commented on this pull request.
I'm not completely sure what you are trying to achieve. Do you have an example Makefile that illustrates your change?
> endif -syn match makeIdent "\$\$\w*"
I don't see why you moved this around to the top unneccessarily…
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
littlewu2508
@littlewu2508 pushed 2 commits.
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
littlewu2508
littlewu2508 left a comment (vim/vim#18403)I'm not completely sure what you are trying to achieve. Do you have an example Makefile that illustrates your change?
Here's my example at work on vim 9.1.1652 (which has same syntax/make.vim as master)
And with these patches:
vimnew.png (view on web)If I didn't move those syn match makeIdent "\$\$\w*" around, it will behave like
Where $$(PJRUN) has only $$ highlighted as makeIdent, I guess this is because syn match makeIdent "\$\$\w*" and syn match makeIdent "\$[^({]" has higher priority to match $$ , just moving this two rule in the front is also OK.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
littlewu2508
littlewu2508 left a comment (vim/vim#18403)Here's my example at work on vim 9.1.1652 (which has same syntax/make.vim as master)
My makefile is
salt.mk.gz
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
littlewu2508
@littlewu2508 commented on this pull request.
> endif -syn match makeIdent "\$\$\w*"
Hi @rohieb, thank you for the comments! Please see my response below and further review.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.