Re: [vim/vim] patch 9.0.1030: using freed memory with the cmdline popup menu (038e6d2)

[zeertzjq]

The test is missing a CheckRunVimInTerminal

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/commit/038e6d20e680ce8c850d07f6b035c4e1904c1201/92419081@github.com>

[Bram Moolenaar]

> The test is missing a `CheckRunVimInTerminal`

Thanks for noticing, I'll make a patch.

--
XML is a nice language for computers. Not for humans.

/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/commit/038e6d20e680ce8c850d07f6b035c4e1904c1201/92439929@github.com>

[Bram Moolenaar]

> > The test is missing a `CheckRunVimInTerminal`
>
> Thanks for noticing, I'll make a patch.

It appears on MS-Windows the colors are different.
Perhaps it helps to explicitly set a colorscheme:

" This was using freed memory. Run in a terminal to get the pum to update.
let lines =<< trim END
colors darkblue
set wildoptions=pum
set wildchar=<C-E>
END


--
Two fish in a tank. One says to the other:
"Do you know how to drive this thing?"

/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/commit/038e6d20e680ce8c850d07f6b035c4e1904c1201/92441833@github.com>

[Bram Moolenaar]

> > > The test is missing a `CheckRunVimInTerminal`
> >
> > Thanks for noticing, I'll make a patch.
>
> It appears on MS-Windows the colors are different.
> Perhaps it helps to explicitly set a colorscheme:
>
> " This was using freed memory. Run in a terminal to get the pum to update.
> let lines =<< trim END
> colors darkblue
> set wildoptions=pum
> set wildchar=<C-E>
> END

Adding the Check command made the test to be skipped. So it can run the
terminal, but the screendumps will differ because of the colors.
I wonder if we can make the colors the same, so that we can test also in
this setup.

--
hundred-and-one symptoms of being an internet addict:
269. You wonder how you can make your dustbin produce Sesame Street's
Oscar's the Garbage Monster song when you empty it.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\