[vim/vim] :tab sbuffer may close old tabpage (PR #19352)

[zeertzjq]

Problem: :tab sbuffer may close old tabpage if BufLeave autocommand
splits window.
Solution: Only close other windows if DOBUF_UNLOAD will be used.

related: neovim/neovim#37749

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/19352

Commit Summary

• 3d9c497 :tab sbuffer may close old tabpage

File Changes

(2 files)

• M src/buffer.c (4)
• M src/testdir/test_buffer.vim (18)

Patch Links:

• https://github.com/vim/vim/pull/19352.patch
• https://github.com/vim/vim/pull/19352.diff

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19352@github.com>

[zeertzjq]

@zeertzjq pushed 1 commit.

• 1d6f8c7 :tab sbuffer may close old tabpage

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19352/before/a86bbf8b32078f3583064fb6ab3d32e8fa754303/after/1d6f8c73cc4a160d74e9e77b6de0c6a87c5b1fc8@github.com>

[zeertzjq]

@zeertzjq pushed 1 commit.

• d0ee4a8 :tab sbuffer may close old tabpage

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19352/before/1d6f8c73cc4a160d74e9e77b6de0c6a87c5b1fc8/after/d0ee4a8d2458c79cc9dbceffdedab917c80a22a3@github.com>

[zeertzjq]

zeertzjq left a comment (vim/vim#19352)

Hmm, there is another case where a window is closed unexpectedly:

tabnew Xa
let b = bufadd('Xb')
autocmd BufLeave Xa ++once split
split
exe 'buffer' b

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19352/c3863124611@github.com>

[zeertzjq]

@zeertzjq pushed 1 commit.

• 5eabcb6 :tab sbuffer may close old tabpage

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19352/before/d0ee4a8d2458c79cc9dbceffdedab917c80a22a3/after/5eabcb6426cb2c0dfab8ba7357450218fd51bb21@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#19352)

thanks

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19352/c3864100745@github.com>

[Christian Brabandt]

Closed #19352 via 6da9f75.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19352/issue_event/22608055118@github.com>